Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsr warmup support #5338

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Conversation

BornChanger
Copy link
Contributor

What problem does this PR solve?

Close #5300

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
    Turn on FSR warmup option, and run EBS snapshot restore. Verify that tikv volumes are warmed up by BR kernel side after EBS volumes are created.
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@BornChanger
Copy link
Contributor Author

/cc @WangLe1321 @YuJuncen

@BornChanger BornChanger requested review from csuzhangxc and removed request for shonge and lichunzhu October 16, 2023 08:41
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

@YuJuncen: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #5338 (7e1376b) into master (bbb73c5) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 55.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5338   +/-   ##
=======================================
  Coverage   61.60%   61.61%           
=======================================
  Files         228      228           
  Lines       28858    28866    +8     
=======================================
+ Hits        17779    17785    +6     
- Misses       9337     9339    +2     
  Partials     1742     1742           
Flag Coverage Δ
unittest 61.61% <55.55%> (+<0.01%) ⬆️

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 09:56:28.490291355 +0000 UTC m=+1650986.077401500: ☑️ agreed by WangLe1321.
  • 2023-10-16 10:08:55.912903725 +0000 UTC m=+1651733.500013854: ✖️🔁 reset by ti-chi-bot[bot].

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

New changes are detected. LGTM label has been removed.

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-br

@BornChanger
Copy link
Contributor Author

/test-pull-e2e-kind

1 similar comment
@BornChanger
Copy link
Contributor Author

/test-pull-e2e-kind

@BornChanger
Copy link
Contributor Author

/test-pull-e2e-kind-br

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-br

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind

@BornChanger
Copy link
Contributor Author

/retest

Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

@BornChanger: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc csuzhangxc merged commit 51c2465 into pingcap:master Oct 20, 2023
5 of 13 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 20, 2023
10 tasks
@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5351.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Oct 20, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
BornChanger added a commit to BornChanger/tidb-operator that referenced this pull request Oct 24, 2023
@BornChanger BornChanger mentioned this pull request Oct 24, 2023
10 tasks
csuzhangxc pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs br: support multiple warmup solution for tikv data volumes
6 participants