Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsr warmup support (#5338) #5357

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Oct 24, 2023

What problem does this PR solve?

Close #5300
A cherry-pick of #5338

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #5357 (05735fa) into release-1.5 (6803b50) will increase coverage by 3.74%.
The diff coverage is 60.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5357      +/-   ##
===============================================
+ Coverage        61.68%   65.42%   +3.74%     
===============================================
  Files              228      241      +13     
  Lines            28840    32764    +3924     
===============================================
+ Hits             17789    21436    +3647     
- Misses            9314     9508     +194     
- Partials          1737     1820      +83     
Flag Coverage Δ
e2e 38.31% <33.33%> (?)
unittest 61.68% <50.00%> (+<0.01%) ⬆️

@BornChanger BornChanger mentioned this pull request Oct 24, 2023
10 tasks
@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-br

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind

@csuzhangxc csuzhangxc merged commit 9c31fbe into pingcap:release-1.5 Oct 25, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants