Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsr warmup support (#5338) #5351

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5338

What problem does this PR solve?

Close #5300

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
    Turn on FSR warmup option, and run EBS snapshot restore. Verify that tikv volumes are warmed up by BR kernel side after EBS volumes are created.
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gozssky for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BornChanger
Copy link
Contributor

/run-pull-e2e-kind-br

@codecov-commenter
Copy link

Codecov Report

Merging #5351 (e023da2) into release-1.5 (6803b50) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5351      +/-   ##
===============================================
+ Coverage        61.68%   61.69%   +0.01%     
===============================================
  Files              228      228              
  Lines            28840    28847       +7     
===============================================
+ Hits             17789    17798       +9     
  Misses            9314     9314              
+ Partials          1737     1735       -2     
Flag Coverage Δ
unittest 61.69% <50.00%> (+0.01%) ⬆️

@BornChanger
Copy link
Contributor

/run-pull-e2e-kind-br

@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

substitute it with #5357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants