Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/stmtsummary: migrate test-infra to testify (part 1) #26870

Merged
merged 5 commits into from
Aug 10, 2021
Merged

util/stmtsummary: migrate test-infra to testify (part 1) #26870

merged 5 commits into from
Aug 10, 2021

Conversation

feitian124
Copy link
Contributor

@feitian124 feitian124 commented Aug 3, 2021 •
edited by tisonkun
Loading

What problem does this PR solve?

Issue Number: ref #26420
split from #26771, [1/2]
based on #26869

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 3, 2021
@feitian124 feitian124 mentioned this pull request Aug 3, 2021
Merged
@feitian124
Copy link
Contributor Author

/cc @tisonkun
hi, please help review, thanks

tisonkun
tisonkun approved these changes Aug 7, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Style comments inline which is not blocker to me.

util/stmtsummary/statement_summary_test.go Outdated Show resolved Hide resolved
util/stmtsummary/statement_summary_test.go Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM. Style comments inline which is not blocker to me.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor

tisonkun commented Aug 7, 2021

/cc @xhebox @xiongjiwei @mmyj

PTAL. Thanks!

@ti-chi-bot ti-chi-bot requested a review from xhebox August 7, 2021 02:21
@ti-chi-bot
Copy link
Member

@tisonkun: GitHub didn't allow me to request PR reviews from the following users: mmyj.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @xhebox @xiongjiwei @mmyj

PTAL. Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 7, 2021
mmyj
mmyj reviewed Aug 9, 2021
View reviewed changes
util/stmtsummary/statement_summary_test.go Outdated Show resolved Hide resolved
util/stmtsummary/statement_summary_test.go Outdated Show resolved Hide resolved
mmyj
mmyj reviewed Aug 9, 2021
View reviewed changes
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, PTAL @xhebox

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 9, 2021
@mmyj
Copy link
Member

mmyj commented Aug 10, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d69505f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2021
@ti-chi-bot
Copy link
Member

@feitian124: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 91c89e4 into pingcap:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmyj mmyj mmyj left review comments

@xhebox xhebox xhebox approved these changes

@tisonkun tisonkun tisonkun approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@feitian124 @ti-chi-bot @tisonkun @mmyj @xhebox @xiongjiwei