Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/stmtsummary: migrate test-infra to testify (part 2) #26871

Merged
merged 12 commits into from
Aug 12, 2021
Merged

util/stmtsummary: migrate test-infra to testify (part 2) #26871

merged 12 commits into from
Aug 12, 2021

Conversation

feitian124
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #26420
split from #26771, [2/2]
based on #26870

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 3, 2021
@feitian124 feitian124 force-pushed the issue-26420-part2 branch 2 times, most recently from 61f78bd to a85a31c Compare August 3, 2021 14:30
@feitian124
Copy link
Contributor Author

/cc @tisonkun
hi, please help review, thanks

@feitian124 feitian124 mentioned this pull request Aug 6, 2021
Merged
tisonkun
tisonkun reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feitian124 plz ping me when part 1 is merged and you squash the diff.

@feitian124
Copy link
Contributor Author

@feitian124 plz ping me when part 1 is merged and you squash the diff.

ok

@feitian124
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 10, 2021
@feitian124
Copy link
Contributor Author

/cc @tisonkun
part0, part1 is merged, please check this last one

tisonkun
tisonkun approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2021
@tisonkun
Copy link
Contributor

/cc @xiongjiwei @mmyj

@ti-chi-bot
Copy link
Member

@tisonkun: GitHub didn't allow me to request PR reviews from the following users: mmyj.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @xiongjiwei @mmyj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2021
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 50a679c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2021
@feitian124
Copy link
Contributor Author

/run-build

@ti-chi-bot
Copy link
Member

@feitian124: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@feitian124
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 26237b3 into pingcap:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@tisonkun tisonkun tisonkun approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for util/stmtsummary pkg
5 participants
@feitian124 @ti-chi-bot @tisonkun @xiongjiwei @xhebox