Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: avoid column allocator reuse the column hold huge memory #32554

Merged
merged 10 commits into from
Feb 23, 2022
Merged

util: avoid column allocator reuse the column hold huge memory #32554

merged 10 commits into from
Feb 23, 2022

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Feb 23, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #31981
close #30880

Problem Summary:
Chunk-rpc will use rpc message to construct chunk directly, which will hold the whole memory.
We should release them after the sql finished.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the problem of tidb oom when exporting data using chunk rpc

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2022
@wshwsh12 wshwsh12 requested a review from tiancaiamao February 23, 2022 06:36
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Feb 23, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2022
@dianqihanwangzi
Copy link
Contributor

/run-readonly-test

@sre-bot
Copy link
Contributor

sre-bot commented Feb 23, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f206f4fee8d85adf624d7f3ec453885473a621dc

@wshwsh12 wshwsh12 requested a review from XuHuaiyu February 23, 2022 08:41
XuHuaiyu
XuHuaiyu reviewed Feb 23, 2022
View reviewed changes
util/chunk/codec.go Outdated
@@ -140,6 +140,7 @@ func (c *Codec) decodeColumn(buffer []byte, col *Column, ordinal int) (remained

// decode data.
col.data = buffer[:numDataBytes:numDataBytes]
// the column reference the data of grpc, so need set col.avoidReusing to avoid reusing it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column reference the data of the grpc response, the memory of the grpc message cannot be GCed if we reuse this column. Thus we set `avoidResuing` to true.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 23, 2022
@wshwsh12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 188e767

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2022
@wshwsh12
Copy link
Contributor Author

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit cce1ebd into pingcap:master Feb 23, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#32554 to release-5.3
e06bc52 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32577

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#32554 to release-5.4
3854bb8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32578

@tiancaiamao tiancaiamao removed the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Feb 24, 2022
ti-chi-bot pushed a commit that referenced this pull request Apr 25, 2022
@ti-srebot
util: avoid column allocator reuse the column hold huge memory (#32554)…
61c1255 
… (#32578)

close #31981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiDB might OOM if dumpling without --params "tidb_enable_chunk_rpc=0" TiDB OOM during dumpling 2500 tables
8 participants
@wshwsh12 @ti-chi-bot @dianqihanwangzi @sre-bot @hawkingrei @ti-srebot @tiancaiamao @XuHuaiyu