Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for @metatag #38

Merged
merged 6 commits into from
Feb 6, 2023
Merged

feat: adds support for @metatag #38

merged 6 commits into from
Feb 6, 2023

Conversation

neveena
Copy link
Contributor

@neveena neveena commented Feb 1, 2023

Version

Published prerelease version: 0.4.0-next.0

Changelog

Release Notes

Bugfix/long lists (#36)

Fixes issues when long constant lists were indexed to create a union.


🚀 Enhancement

🐛 Bug Fix

Authors: 2

@neveena neveena requested a review from adierkens as a code owner February 1, 2023 17:56
@KetanReddy
Copy link
Member

Please add some tests to verify the expected behavior.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 53.33% // Head: 55.11% // Increases project coverage by +1.77% 🎉

Coverage data is based on head (914c23b) compared to base (3ecf732).
Patch coverage: 71.42% of modified lines in pull request are covered.

❗ Current head 914c23b differs from pull request most recent head 5a005bf. Consider uploading reports for the commit 5a005bf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   53.33%   55.11%   +1.77%     
==========================================
  Files          56       56              
  Lines        2996     3003       +7     
  Branches      890      894       +4     
==========================================
+ Hits         1598     1655      +57     
+ Misses       1124     1045      -79     
- Partials      274      303      +29     
Impacted Files Coverage Δ
xlr/utils/src/test-helpers.ts 100.00% <ø> (+100.00%) ⬆️
xlr/utils/src/annotations.ts 51.02% <71.42%> (+51.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@neveena
Copy link
Contributor Author

neveena commented Feb 6, 2023

Please add some tests to verify the expected behavior.

@KetanReddy added unit tests 👍

@KetanReddy KetanReddy added the minor Increment the minor version when merged label Feb 6, 2023
@KetanReddy KetanReddy enabled auto-merge (squash) February 6, 2023 21:02
@KetanReddy KetanReddy disabled auto-merge February 6, 2023 21:17
@KetanReddy KetanReddy merged commit 635e303 into player-ui:main Feb 6, 2023
Comment on lines +27 to +28
* @meta category:views
* @meta screenshot:/path/image.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care if multiple tags contain the same category names?

Example

* @meta category:AAA
* @meta category:BBB

@intuit-svc intuit-svc mentioned this pull request Oct 18, 2023
@intuit-svc intuit-svc mentioned this pull request Nov 6, 2023
6 tasks
@intuit-svc intuit-svc mentioned this pull request Nov 15, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants