Add test cases for some weird issues with Event content type #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@idgserpro I tested both weird issues we are having in collective.cover and was not able to reproduce them here; I think we have a problem in our test suite setup and we would need some help. |
|
@idgserpro any feedback? |
|
@idgserpro I tested locally in my own machine and tests are passing; you can do the same. |
|
yes they do, and that's why I think we have a problem with the test fixture. |
idgserpro
reviewed
Aug 14, 2018
| @@ -376,6 +376,46 @@ def test_create_at_with_title_in_request(self): | |||
|
|
|||
| self.assertEqual(page.title, 'Test document') | |||
|
|
|||
| @unittest.skipIf(HAS_PACONTENTYPES, 'Archetypes only') | |||
| def test_create_at_event(self): | |||
There was a problem hiding this comment.
Archetypes is going to die soon.
This was referenced Sep 4, 2018
idgserpro
reviewed
Sep 6, 2018
|
|
||
| @unittest.skipUnless(HAS_PACONTENTYPES, 'Dexterity only') | ||
| def test_create_dx_event(self): | ||
| """https://github.com/plone/plone.app.contenttypes/issues/465""" |
There was a problem hiding this comment.
@hvelarde what's the relationship between plone/plone.app.contenttypes#465 and plone.api? It seems to me more a problem of plone.app.contenttypes. What's purpose of this test?
@gbastien FYI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test only; do not merge!