-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test to confirm error in Archetype Collection creation #410
Conversation
@hvelarde note that the error that occurs in creating the collection occurs here as well. |
now we must open an issue describing the problem :) |
@gbastien already opened the issue for us. |
Hi @idgserpro I did not see this PR... We have the same problem, still need to decide how to fix it... Gauthier |
I can confirm that if I change {None: None} to {'':''}, bool({'':''} is still True so it is used by AT's processForm and the test you added pass as well as the test_create_at_with_title_in_request that was added regarding the {None: None}. So I would go for that, what do you think? Gauthier |
if tests pass I think it could be fine; just be careful to not reintroduce another issue with Archetypes-based Event content type. I would suggest to add tests on #407 to this pull request as well. |
@idgserpro ok I will create a separated PR and keep your test. @hvelarde so I would add the tests of PR #407 as well to the new PR to make sure it works with AT and DX event? I totally agree, why PR #407 was not merged? I will propose a PR tomorrow with all this together. Thank you for review, Gauthier |
@gbastien it was not merged because I though it was unnecessary, but @idgserpro was right and now I think is important to avoid regressions. |
Replaced for #414 |
refs. #413