Fix falining AT Collection creation when using api.content.create. #414
Conversation
|
Hi @idgserpro FYI |
…ils because of a bug in plone.api==1.8.4. See plone/plone.api#414
src/plone/api/tests/test_content.py
Outdated
|
|
||
| @unittest.skipUnless(HAS_PACONTENTYPES, 'Dexterity only') | ||
| def test_create_dx_event(self): | ||
| """https://github.com/plone/plone.app.contenttypes/issues/465""" |
There was a problem hiding this comment.
@hvelarde what's the relationship between plone/plone.app.contenttypes#465 and plone.api? It seems to me more a problem of plone.app.contenttypes.
I think this test can continue but without reference to plone.app.contenttypes.
There was a problem hiding this comment.
IIRC, I was unable to reproduce it on a clean Plone installation; so maybe it's not related at all; we may remove the reference.
There was a problem hiding this comment.
I fixed the typos and run test for AT and DX and Travis is green.
I kept the test regarding the event creation, do not know if it is necessary now that we have a test with Collection creation for AT and DX?
There was a problem hiding this comment.
In fact what avoids #364 is the AT test. But it's good to have an event creation test with DX
There was a problem hiding this comment.
OK so I would remove the test_create_at_event, unnecessary now because of test_create_collection?
There was a problem hiding this comment.
Right, so let's merge? :-)
There was a problem hiding this comment.
@gbastien I think it is necessary now only to remove the reference:
plone/plone.app.contenttypes#465
in docstring.
src/plone/api/tests/test_content.py
Outdated
| @@ -376,6 +376,64 @@ def test_create_at_with_title_in_request(self): | |||
|
|
|||
| self.assertEqual(page.title, 'Test document') | |||
|
|
|||
| @unittest.skipIf(HAS_PACONTENTYPES, 'Archetypes only') | |||
There was a problem hiding this comment.
@gbastien thinking minor, I think this test should run with dx too. Collection creation should work with dx. You can remove this condition and change the name of the test.
CHANGES.rst
Outdated
| @@ -21,6 +21,9 @@ Bug fixes: | |||
| - fix typos in doc strings | |||
| [tkimnguyen] | |||
|
|
|||
| - Fix falining AT Collection creation when using api.content.create. | |||
src/plone/api/tests/test_content.py
Outdated
| @@ -376,6 +376,64 @@ def test_create_at_with_title_in_request(self): | |||
|
|
|||
| self.assertEqual(page.title, 'Test document') | |||
|
|
|||
| @unittest.skipIf(HAS_PACONTENTYPES, 'Archetypes only') | |||
| def test_create_at_collection(self): | |||
| """Test create at Collecition.""" | |||
|
@gbastien you need to run the Jenkins jobs also. |
src/plone/api/tests/test_content.py
Outdated
|
|
||
| @unittest.skipUnless(HAS_PACONTENTYPES, 'Dexterity only') | ||
| def test_create_dx_event(self): | ||
| """ """ |
There was a problem hiding this comment.
it doesn't make sense to have an empty docstring.
|
@hvelarde ready to merge ? ;-) |
|
I prefer to leave it to one @plone/framework-team member. |
This test confirms the fix for plone/plone.api#414.
|
@plone/release-team can we have a new release, please? |
|
@hvelarde done: https://pypi.org/project/plone.api/ 1.8.6 |
|
@gforcada in fact, it's 1.8.5. |
I also added the AT/DX event creation related tests from PR #407.
With this, the Collection creation is correct.
Thank you,
Gauthier