Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impossible to insert a picture already available on the website (Internal Image) #77

Closed
serge73 opened this issue Mar 14, 2016 · 24 comments · Fixed by #83
Closed

impossible to insert a picture already available on the website (Internal Image) #77

serge73 opened this issue Mar 14, 2016 · 24 comments · Fixed by #83

Comments

@serge73
Copy link

serge73 commented Mar 14, 2016

When upgrading plone.app.content to version 3.0.18 or above, it is impossible to insert a picture already available on the website (Internal Image) to the Page.

The picture file is not recorded in the drop-down menu.

2016-03-15_0-51-44

@davilima6
Copy link
Member

Which browser is this? Any console errors? I couldn't reproduce with Firefox/Ubuntu and p.a.content 3.0.20 (5.3-pending). Is this only after an upgrade? Does it work for you in vanilla 5.3-pending?

@serge73
Copy link
Author

serge73 commented Mar 22, 2016

I tested p.a.content 3.0.20 and 3.0.17:
Server is Debian i386 latest stable
Client:
a) Windows 10 (two different PC). Latest IE, chrome, Opera
b) Debian latest Opera

Firefox (win) and Icewiasel (Debian) do not load the TinyMCE toolbar. Check out quickly was not able.

Will try to test using Ubuntu on VM Ware. What version of Ubuntu you used?
What did you do when upgrading from 5.0.2 to 5.0.3?

@davilima6
Copy link
Member

I didn't try upgrading. Is this an upgrade-only issue?

I tested on Ubuntu 15.10. And now I also tested with Windows browsers, newest stable Chrome and FF, and it's ok too.

@serge73
Copy link
Author

serge73 commented Mar 22, 2016

On Plone 5.0.2 under the above conditions p.a.c 3.0.20 does not work, as with 5.0.3.

Plone 5.0.2 + 3.0.17 without any problems.

I need to install a fresh OS and Plone to make a video. :)

@vangheem
Copy link
Member

@serge73 Are there any errors in the browser console?

It's also not clear if you tried this on a fresh install or if this is only happening on your upgraded instance?

@serge73
Copy link
Author

serge73 commented Mar 22, 2016

Unexpectedly found another solution for 3.0.20: installing site language to English!

The problem appears when using Russian, Polish, African and probably any other non-English

P.S.: In my experiments I always used Russian in 5.0.2 and 5.0.3. So I did not try to change the language.

@serge73
Copy link
Author

serge73 commented Mar 22, 2016

Please set the Russian or any other non-English and test issue:
2016-03-22_22-31-21
Console if you installed the Russian:
2016-03-22_22-34-18
Console if you installed the English:
2016-03-22_22-39-14

@serge73
Copy link
Author

serge73 commented Mar 22, 2016

In Plone version 5.0.3, the problem is solved similarly to language change.

@davilima6
Copy link
Member

Indeed I tested without upgrading but choosing pt-br when adding the site and couldn't even select the added image. Thus I also couldn't insert a picture in Tiny. Here's my console:

captura de tela 2016-03-22 17 07 27

@vangheem
Copy link
Member

Looks like vocabulary content results, like portal_type, are getting translated and screwing things up:

f167266
and
92e9749

seem to be responsible.

\cc @terapyon

@serge73
Copy link
Author

serge73 commented Apr 5, 2016

Wanted to try to install the English only for the admin.
But the site does not change the language remains a language which is default for the site.
A global problem with the use of languages other than English.

Advise where to place the information for specialists, what would it drew attention.

2016-04-05_10-12-02

@vangheem
Copy link
Member

vangheem commented Apr 5, 2016

It should be an easy fix in plone.app.content. portal_type should not be getting translated. ping @terapyon

@thet
Copy link
Member

thet commented Apr 5, 2016

I have another issue with a translated portal_type which I'm going to fix here: aab7f4c
I think I can take care of this too.

@jensens
Copy link
Member

jensens commented Apr 5, 2016

portal_type must never be translated. It is expected as a stable identifier for the type, the id in the types tool. The Type (iirc this is always the title of the FTI) is what you want to display and translate.

thet added a commit that referenced this issue Apr 5, 2016
Added most notably `portal_type`, `review_state` and `Subject` but also `exclude_from_nav`, `is_folderish`, `last_comment_date`, `meta_type` and `total_comments` to ``BaseVocabularyView`` ``translate_ignored`` list.
Some of them are necessary for frontend logic and others cannot be translated.
Fixes #77
@thet
Copy link
Member

thet commented Apr 5, 2016

Fixed here: 1a45137

thet added a commit that referenced this issue Apr 5, 2016
Added most notably `portal_type`, `review_state` and `Subject` but also `exclude_from_nav`, `is_folderish`, `last_comment_date`, `meta_type` and `total_comments` to ``BaseVocabularyView`` ``translate_ignored`` list.
Some of them are necessary for frontend logic and others cannot be translated.
Fixes #77
@davilima6
Copy link
Member

@serge73, thank you for the report on the user language preference bug. Would you mind opening it as a separate issue? Btw I tested and confirm this is indeed a regression: the setting in @@personal-preferences causes no effect.

@serge73
Copy link
Author

serge73 commented Apr 6, 2016

davilima6, no problem.
Set language for selected user
Please confirm.

thet added a commit that referenced this issue Apr 6, 2016
Added most notably `portal_type`, `review_state` and `Subject` but also `exclude_from_nav`, `is_folderish`, `last_comment_date`, `meta_type` and `total_comments` to ``BaseVocabularyView`` ``translate_ignored`` list.
Some of them are necessary for frontend logic and others cannot be translated.
Fixes #77
@terapyon
Copy link
Member

terapyon commented Apr 8, 2016

Sorry too late, I'll check this issue.

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Apr 8, 2016
Branch: refs/heads/master
Date: 2016-04-07T00:24:27+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.content@115c8db

Format for easier readability.

Files changed:
M plone/app/content/browser/contents/__init__.py
M plone/app/content/browser/vocabulary.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-04-07T00:24:27+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.content@68abf18

More available columns in folder_contents.
Add ``Creator``, ``Description``, ``end``, ``start`` and ``location`` to the available columns and context attributes for folder_contents.
Exclude ``Creator`` from the list of ``_unsafe_metadata``.

Files changed:
M CHANGES.rst
M plone/app/content/browser/contents/__init__.py
M plone/app/content/browser/vocabulary.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-04-07T00:25:27+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.content@c7b07b8

Show attributes from ``_unsafe_metadata`` if user has "Modify Portal Content" permissions.

Files changed:
M CHANGES.rst
M plone/app/content/browser/vocabulary.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-04-07T00:25:27+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.content@cbb6938

Remove ``portal_type`` from available columns and use the translated ``Type`` instead.
``portal_type`` is now available on the attributes object.

Files changed:
M CHANGES.rst
M plone/app/content/browser/contents/__init__.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-04-07T00:26:35+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.content@3b529a3

Extend translation ignore list for metadata values in vocabulary
Added most notably `portal_type`, `review_state` and `Subject` but also `exclude_from_nav`, `is_folderish`, `last_comment_date`, `meta_type` and `total_comments` to ``BaseVocabularyView`` ``translate_ignored`` list.
Some of them are necessary for frontend logic and others cannot be translated.
Fixes plone/plone.app.content#77

Files changed:
M CHANGES.rst
M plone/app/content/browser/vocabulary.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-04-08T08:57:01+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.content@59f1b26

Merge pull request #83 from plone/thet-fcmorecolumns

 More available columns in folder_contents.

Files changed:
M CHANGES.rst
M plone/app/content/browser/contents/__init__.py
M plone/app/content/browser/vocabulary.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Apr 8, 2016
Branch: refs/heads/master
Date: 2016-04-07T00:24:27+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.content@115c8db

Format for easier readability.

Files changed:
M plone/app/content/browser/contents/__init__.py
M plone/app/content/browser/vocabulary.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-04-07T00:24:27+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.content@68abf18

More available columns in folder_contents.
Add ``Creator``, ``Description``, ``end``, ``start`` and ``location`` to the available columns and context attributes for folder_contents.
Exclude ``Creator`` from the list of ``_unsafe_metadata``.

Files changed:
M CHANGES.rst
M plone/app/content/browser/contents/__init__.py
M plone/app/content/browser/vocabulary.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-04-07T00:25:27+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.content@c7b07b8

Show attributes from ``_unsafe_metadata`` if user has "Modify Portal Content" permissions.

Files changed:
M CHANGES.rst
M plone/app/content/browser/vocabulary.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-04-07T00:25:27+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.content@cbb6938

Remove ``portal_type`` from available columns and use the translated ``Type`` instead.
``portal_type`` is now available on the attributes object.

Files changed:
M CHANGES.rst
M plone/app/content/browser/contents/__init__.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-04-07T00:26:35+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.app.content@3b529a3

Extend translation ignore list for metadata values in vocabulary
Added most notably `portal_type`, `review_state` and `Subject` but also `exclude_from_nav`, `is_folderish`, `last_comment_date`, `meta_type` and `total_comments` to ``BaseVocabularyView`` ``translate_ignored`` list.
Some of them are necessary for frontend logic and others cannot be translated.
Fixes plone/plone.app.content#77

Files changed:
M CHANGES.rst
M plone/app/content/browser/vocabulary.py
Repository: plone.app.content
Branch: refs/heads/master
Date: 2016-04-08T08:57:01+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.content@59f1b26

Merge pull request #83 from plone/thet-fcmorecolumns

 More available columns in folder_contents.

Files changed:
M CHANGES.rst
M plone/app/content/browser/contents/__init__.py
M plone/app/content/browser/vocabulary.py
@1letter
Copy link
Contributor

1letter commented Apr 22, 2016

I have the same issue in my Plone 5.0.4 installation. when i set the language to "German", i could not insert a internal image, i can see no js-errors in the console. But when i set the language to "English", then all is fine. Only the js error with the wrong Filename en_gb.js vs. en_EN.js is show in the console.

@thet
Copy link
Member

thet commented Apr 22, 2016

This should already be fixed in latest plone.app.content

@1letter
Copy link
Contributor

1letter commented Apr 22, 2016

Oh, and what ist the latest version? 3.0.20 via pypi wich is installed on my system or is this the master-branch this git-repro? I used the normal tar-installer-file of plone. i'm confused, sorry.

@davilima6
Copy link
Member

@1letter, I believe @thet was referring to 3.0.21 unreleased as you can see here: https://github.com/plone/plone.app.content/blob/master/CHANGES.rst

@thet, could you please make a release? There seems to be multiple issues open for this bug.

@thet
Copy link
Member

thet commented Apr 26, 2016

@davilima6 I don't have pypi rights for that.

I think the next release is worth a minor version bump - I raised the version to 3.1.
@plone/release-team can you please make a release?

@gforcada
Copy link
Member

plone.app.content 3.1 is released: https://pypi.python.org/pypi/plone.app.content/3.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants