-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impossible to insert a picture already available on the website (Internal Image) #77
Comments
Which browser is this? Any console errors? I couldn't reproduce with Firefox/Ubuntu and p.a.content 3.0.20 (5.3-pending). Is this only after an upgrade? Does it work for you in vanilla 5.3-pending? |
I tested p.a.content 3.0.20 and 3.0.17: Firefox (win) and Icewiasel (Debian) do not load the TinyMCE toolbar. Check out quickly was not able. Will try to test using Ubuntu on VM Ware. What version of Ubuntu you used? |
I didn't try upgrading. Is this an upgrade-only issue? I tested on Ubuntu 15.10. And now I also tested with Windows browsers, newest stable Chrome and FF, and it's ok too. |
On Plone 5.0.2 under the above conditions p.a.c 3.0.20 does not work, as with 5.0.3. Plone 5.0.2 + 3.0.17 without any problems. I need to install a fresh OS and Plone to make a video. :) |
@serge73 Are there any errors in the browser console? It's also not clear if you tried this on a fresh install or if this is only happening on your upgraded instance? |
Unexpectedly found another solution for 3.0.20: installing site language to English! The problem appears when using Russian, Polish, African and probably any other non-English P.S.: In my experiments I always used Russian in 5.0.2 and 5.0.3. So I did not try to change the language. |
In Plone version 5.0.3, the problem is solved similarly to language change. |
It should be an easy fix in plone.app.content. portal_type should not be getting translated. ping @terapyon |
I have another issue with a translated portal_type which I'm going to fix here: aab7f4c |
|
Added most notably `portal_type`, `review_state` and `Subject` but also `exclude_from_nav`, `is_folderish`, `last_comment_date`, `meta_type` and `total_comments` to ``BaseVocabularyView`` ``translate_ignored`` list. Some of them are necessary for frontend logic and others cannot be translated. Fixes #77
Fixed here: 1a45137
|
Added most notably `portal_type`, `review_state` and `Subject` but also `exclude_from_nav`, `is_folderish`, `last_comment_date`, `meta_type` and `total_comments` to ``BaseVocabularyView`` ``translate_ignored`` list. Some of them are necessary for frontend logic and others cannot be translated. Fixes #77
@serge73, thank you for the report on the user language preference bug. Would you mind opening it as a separate issue? Btw I tested and confirm this is indeed a regression: the setting in @@personal-preferences causes no effect. |
davilima6, no problem. |
Added most notably `portal_type`, `review_state` and `Subject` but also `exclude_from_nav`, `is_folderish`, `last_comment_date`, `meta_type` and `total_comments` to ``BaseVocabularyView`` ``translate_ignored`` list. Some of them are necessary for frontend logic and others cannot be translated. Fixes #77
Sorry too late, I'll check this issue. |
Branch: refs/heads/master Date: 2016-04-07T00:24:27+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@115c8db Format for easier readability. Files changed: M plone/app/content/browser/contents/__init__.py M plone/app/content/browser/vocabulary.py Repository: plone.app.content Branch: refs/heads/master Date: 2016-04-07T00:24:27+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@68abf18 More available columns in folder_contents. Add ``Creator``, ``Description``, ``end``, ``start`` and ``location`` to the available columns and context attributes for folder_contents. Exclude ``Creator`` from the list of ``_unsafe_metadata``. Files changed: M CHANGES.rst M plone/app/content/browser/contents/__init__.py M plone/app/content/browser/vocabulary.py Repository: plone.app.content Branch: refs/heads/master Date: 2016-04-07T00:25:27+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@c7b07b8 Show attributes from ``_unsafe_metadata`` if user has "Modify Portal Content" permissions. Files changed: M CHANGES.rst M plone/app/content/browser/vocabulary.py Repository: plone.app.content Branch: refs/heads/master Date: 2016-04-07T00:25:27+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@cbb6938 Remove ``portal_type`` from available columns and use the translated ``Type`` instead. ``portal_type`` is now available on the attributes object. Files changed: M CHANGES.rst M plone/app/content/browser/contents/__init__.py Repository: plone.app.content Branch: refs/heads/master Date: 2016-04-07T00:26:35+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@3b529a3 Extend translation ignore list for metadata values in vocabulary Added most notably `portal_type`, `review_state` and `Subject` but also `exclude_from_nav`, `is_folderish`, `last_comment_date`, `meta_type` and `total_comments` to ``BaseVocabularyView`` ``translate_ignored`` list. Some of them are necessary for frontend logic and others cannot be translated. Fixes plone/plone.app.content#77 Files changed: M CHANGES.rst M plone/app/content/browser/vocabulary.py Repository: plone.app.content Branch: refs/heads/master Date: 2016-04-08T08:57:01+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.content@59f1b26 Merge pull request #83 from plone/thet-fcmorecolumns More available columns in folder_contents. Files changed: M CHANGES.rst M plone/app/content/browser/contents/__init__.py M plone/app/content/browser/vocabulary.py
Branch: refs/heads/master Date: 2016-04-07T00:24:27+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@115c8db Format for easier readability. Files changed: M plone/app/content/browser/contents/__init__.py M plone/app/content/browser/vocabulary.py Repository: plone.app.content Branch: refs/heads/master Date: 2016-04-07T00:24:27+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@68abf18 More available columns in folder_contents. Add ``Creator``, ``Description``, ``end``, ``start`` and ``location`` to the available columns and context attributes for folder_contents. Exclude ``Creator`` from the list of ``_unsafe_metadata``. Files changed: M CHANGES.rst M plone/app/content/browser/contents/__init__.py M plone/app/content/browser/vocabulary.py Repository: plone.app.content Branch: refs/heads/master Date: 2016-04-07T00:25:27+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@c7b07b8 Show attributes from ``_unsafe_metadata`` if user has "Modify Portal Content" permissions. Files changed: M CHANGES.rst M plone/app/content/browser/vocabulary.py Repository: plone.app.content Branch: refs/heads/master Date: 2016-04-07T00:25:27+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@cbb6938 Remove ``portal_type`` from available columns and use the translated ``Type`` instead. ``portal_type`` is now available on the attributes object. Files changed: M CHANGES.rst M plone/app/content/browser/contents/__init__.py Repository: plone.app.content Branch: refs/heads/master Date: 2016-04-07T00:26:35+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@3b529a3 Extend translation ignore list for metadata values in vocabulary Added most notably `portal_type`, `review_state` and `Subject` but also `exclude_from_nav`, `is_folderish`, `last_comment_date`, `meta_type` and `total_comments` to ``BaseVocabularyView`` ``translate_ignored`` list. Some of them are necessary for frontend logic and others cannot be translated. Fixes plone/plone.app.content#77 Files changed: M CHANGES.rst M plone/app/content/browser/vocabulary.py Repository: plone.app.content Branch: refs/heads/master Date: 2016-04-08T08:57:01+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.content@59f1b26 Merge pull request #83 from plone/thet-fcmorecolumns More available columns in folder_contents. Files changed: M CHANGES.rst M plone/app/content/browser/contents/__init__.py M plone/app/content/browser/vocabulary.py
I have the same issue in my Plone 5.0.4 installation. when i set the language to "German", i could not insert a internal image, i can see no js-errors in the console. But when i set the language to "English", then all is fine. Only the js error with the wrong Filename en_gb.js vs. en_EN.js is show in the console. |
This should already be fixed in latest plone.app.content |
Oh, and what ist the latest version? 3.0.20 via pypi wich is installed on my system or is this the master-branch this git-repro? I used the normal tar-installer-file of plone. i'm confused, sorry. |
@1letter, I believe @thet was referring to 3.0.21 unreleased as you can see here: https://github.com/plone/plone.app.content/blob/master/CHANGES.rst @thet, could you please make a release? There seems to be multiple issues open for this bug. |
@davilima6 I don't have pypi rights for that. I think the next release is worth a minor version bump - I raised the version to 3.1. |
plone.app.content 3.1 is released: https://pypi.python.org/pypi/plone.app.content/3.1 🎉 |
When upgrading plone.app.content to version 3.0.18 or above, it is impossible to insert a picture already available on the website (Internal Image) to the Page.
The picture file is not recorded in the drop-down menu.
The text was updated successfully, but these errors were encountered: