More available columns in folder_contents.

[thet]

Follow up of #78 and obsoletes that. The other one contained the test isolation fixes branch, which failed through the jenkins test. Therefore this new branch with two more features/commits.

• Add Creator, Description, end, start and location to the available columns and context attributes for folder_contents.
• Show attributes from _unsafe_metadata if user has "Modify Portal Content" permissions.
• Remove portal_type from available columns and use Type instead, which is meant to be read by humans.
  portal_type is now available on the attributes object.
• Added most notably portal_type, review_state and Subject but also exclude_from_nav, is_folderish, last_comment_date, meta_type and total_comments to BaseVocabularyView translate_ignored list.
  Some of them are necessary for frontend logic and others cannot be translated.
  Fixes impossible to insert a picture already available on the website (Internal Image) #77

[jensens]

hmm, this should go into 5.1 only, since the type -> portal_type change

[thet]

a translated Types was once used here, where it was changed to portal_types:
cc0158e

Looks like an accident...

[thet]

Regarding "Extend translation ignore list for metadata values in vocabulary ", 1a45137
From the current set of portal catalog metadata, only Type is left to be translated.

[thet]

@vangheem can you have a look at this PR, especially these commits?

1. 5ac4636

Show attributes from _unsafe_metadata if user has "Modify Portal Content" permissions.

2. 1a45137

Extend translation ignore list for metadata values in vocabulary
Added most notably portal_type, review_state and Subject but also exclude_from_nav, is_folderish, last_comment_date, meta_type and total_comments to BaseVocabularyView translate_ignored list.
Some of them are necessary for frontend logic and others cannot be translated.
Fixes #77

[thet]

Sorry for packing again too much into one singe PR. At least it's different commits, so if it's necessary (controversy on individual commits), I can split that apart.

[jensens]

lgtm, any reason to not merge?

[agitator]

yes please

[thet]

@terapyon this commit 3b529a3 fixes an issue you introduced in f167266 and 92e9749
I understand the intention of your fix, but it broke things at other places.
Only Type is left from the catalog metadata to be translated by default (except you use other metdata, which make sense translating). I'm not sure, if my fix goes that much against the intention of your commits, that we could also avoid translating at all...

[terapyon]

Thank you for fixing the bug. I will check it out again.

[pysailor]

@thet Hi, I'm a bit confused. In folder_contents, the getVocabulary view is called on the portal. Therefore the context is the portal.
Why does a user need to have "Modify portal content" globally on the portal to be able to view the Creator column in any subfolder?
Why is Creator considered unsafe in the first place?

[thet]

Having this info exposed could be considered unsafe in some use cases. What I did, was instead of never exposing those unsafe metadata, they are now exposed if the user has "Modify portal content" - on the context itself. Before, these metadata columns were just skipped.

I'm fine with these columns being unsafe, but maybe @vangheem can give some more insight. He added it in:

plone/plone.app.widgets@5055725#diff-83a9a1cb178e6b38717c2427eac08433R27
and
plone/plone.app.widgets@fd5c8cf#diff-cc8621ac4fb1caf4495921abbc02f895R33