Added global form state. #5721
Merged
Added global form state. #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for volto canceled.
|
robgietema
force-pushed
the
global-form-state
branch
from
46b4ae1 to
0b01c84
Compare
davisagli
reviewed
Feb 1, 2024
sneridagh
reviewed
Feb 1, 2024
robgietema
force-pushed
the
global-form-state
branch
from
26a494d to
b5762b9
Compare
|
What's the intention to make the being edited content (data of the edit form) available from global app store? Could BTW the first step for an auto save feature… |
robgietema
force-pushed
the
global-form-state
branch
3 times, most recently
from
3215bc5 to
8631bd3
Compare
robgietema
force-pushed
the
global-form-state
branch
from
8631bd3 to
1c0b76b
Compare
|
@ksuess see the description: #5721 (comment) |
tiberiuichim
approved these changes
Feb 6, 2024
|
@stevepiercy I will merge this right away. I promise docs after we get the right dynamics once we start applying and using this in the wild. |
sneridagh
added a commit
that referenced
this pull request
Feb 7, 2024
stevepiercy
pushed a commit
that referenced
this pull request
Feb 13, 2024
sneridagh
added a commit
that referenced
this pull request
Feb 15, 2024
…bars-et-al * main: (56 commits) Exclude chromewebstore from linkcheck (#5761) (feat):App extras exceptions (#5621) Add VOLTOCONFIG Env Var (#5752) PoC - Vite and Tanstack Router, Query and `@plone/client` in SSR mode. (#5750) Update links to Redux and React developer extensions for Chrome (#5757) Overhaul environment variables documentation (#5736) Mention what version the 'links and references' view was added (#5756) Add wait commands to flaky block-listing tests (#5753) Fix logging in test-acceptance-server commands (#5748) Replaced outdated diff with a link to the current `package.json` on t… (#5728) Listing Block render of initial results in SSR (#5689) Fix @plone/volto-slate path in moduleNameMapper (#5743) Added global form state. (#5721) Release generate-volto 9.0.0-alpha.5 Fix tests in projects that involves TS files (#5738) Reorganize README, merging content into authoritative locations (#5511) Release 18.0.0-alpha.10 Release generate-volto 9.0.0-alpha.4 Release @plone/registry 1.2.2 Enhance release in @plone/registry ...
sneridagh
added a commit
that referenced
this pull request
Feb 23, 2024
sneridagh
added a commit
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main block's form controls the state in the Form component itself. This forces to drill the state and its handlers through all the descendants tree, which is cumbersome. Also, this results in some limitations, since the state can't be access from outside this tree of descendants (eg. the header or footer components).
Having the state lifted to be global and provide the handlers via a React Context would allow: