Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VOLTOCONFIG Env Var #5752

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Add VOLTOCONFIG Env Var #5752

merged 6 commits into from
Feb 13, 2024

Conversation

sneridagh
Copy link
Member

No description provided.

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for volto ready!

Name Link
🔨 Latest commit d233acb
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65cb28565a21a40008e33344
😎 Deploy Preview https://deploy-preview-5752--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit d233acb
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65cb285628fc6000084ef86d

@stevepiercy
Copy link
Collaborator

@sneridagh there is another open PR for environment variables documentation that needs some review and love before the docs from this one can be included.

@sneridagh
Copy link
Member Author

@stevepiercy updated.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks and MyST seasoning.

docs/source/configuration/environmentvariables.md Outdated Show resolved Hide resolved
docs/source/configuration/environmentvariables.md Outdated Show resolved Hide resolved
docs/source/configuration/volto-config-js.md Outdated Show resolved Hide resolved
docs/source/configuration/volto-config-js.md Outdated Show resolved Hide resolved
docs/source/configuration/volto-config-js.md Outdated Show resolved Hide resolved
packages/registry/news/5752.feature Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

Outside the scope of this issue, of course, but copy-paste in docs always leads to drift and more maintenance work. I wonder if we should audit the Configuration section and reorganize it? I can create an issue for future work, and add it to the GSoD draft proposal.

Co-authored-by: Steve Piercy <web@stevepiercy.com>
@sneridagh
Copy link
Member Author

@stevepiercy I thought on it already, but it's so small, and it won't change...

@stevepiercy stevepiercy dismissed their stale review February 13, 2024 08:42

Docs look good, dunno about code.

@sneridagh sneridagh merged commit 3a071a8 into main Feb 13, 2024
65 checks passed
@sneridagh sneridagh deleted the addVOLTOCONFIGEnvVar branch February 13, 2024 09:22
sneridagh added a commit that referenced this pull request Feb 15, 2024
…bars-et-al

* main: (56 commits)
  Exclude chromewebstore from linkcheck (#5761)
  (feat):App extras exceptions (#5621)
  Add VOLTOCONFIG Env Var (#5752)
  PoC - Vite and Tanstack Router, Query and `@plone/client` in SSR mode. (#5750)
  Update links to Redux and React developer extensions for Chrome (#5757)
  Overhaul environment variables documentation (#5736)
  Mention what version the 'links and references' view was added (#5756)
  Add wait commands to flaky block-listing tests (#5753)
  Fix logging in test-acceptance-server commands (#5748)
  Replaced outdated diff with a link to the current `package.json` on t… (#5728)
  Listing Block render of initial results in SSR (#5689)
  Fix @plone/volto-slate path in moduleNameMapper (#5743)
  Added global form state. (#5721)
  Release generate-volto 9.0.0-alpha.5
  Fix tests in projects that involves TS files (#5738)
  Reorganize README, merging content into authoritative locations (#5511)
  Release 18.0.0-alpha.10
  Release generate-volto 9.0.0-alpha.4
  Release @plone/registry 1.2.2
  Enhance release in @plone/registry
  ...
sneridagh added a commit that referenced this pull request Feb 18, 2024
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants