-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC - Vite and Tanstack Router, Query and @plone/client
in SSR mode.
#5750
Conversation
✅ Deploy Preview for volto canceled.
|
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, minor grammar fixes and a link fix.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README and CI looks good. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch on nextjs/README.md. CI and README looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try this to workaround the readme check failure.
If it works, then you can remove the whitelist item in the CI that you added in an attempt to get it to pass.
@stevepiercy it still fails... |
oh lol |
This should fail, I hope, and if it does, then I will update the whitelist item.
I learned to Internet this many years ago 0️⃣ . lol. All right, that readme is good to go now. Just needs a change log and update branch. Back to you @sneridagh. |
@stevepiercy thanks! |
…bars-et-al * main: (56 commits) Exclude chromewebstore from linkcheck (#5761) (feat):App extras exceptions (#5621) Add VOLTOCONFIG Env Var (#5752) PoC - Vite and Tanstack Router, Query and `@plone/client` in SSR mode. (#5750) Update links to Redux and React developer extensions for Chrome (#5757) Overhaul environment variables documentation (#5736) Mention what version the 'links and references' view was added (#5756) Add wait commands to flaky block-listing tests (#5753) Fix logging in test-acceptance-server commands (#5748) Replaced outdated diff with a link to the current `package.json` on t… (#5728) Listing Block render of initial results in SSR (#5689) Fix @plone/volto-slate path in moduleNameMapper (#5743) Added global form state. (#5721) Release generate-volto 9.0.0-alpha.5 Fix tests in projects that involves TS files (#5738) Reorganize README, merging content into authoritative locations (#5511) Release 18.0.0-alpha.10 Release generate-volto 9.0.0-alpha.4 Release @plone/registry 1.2.2 Enhance release in @plone/registry ...
No description provided.