Fix logging in test-acceptance-server commands #5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
✅ Deploy Preview for plone-components canceled.
|
|
@sneridagh Why is the changelog check complaining? This is a change to the root level of the repository, not a package. |
ichim-david
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
@davisagli
Thanks for your work! I felt bad if this was the only thing needed but seeing the extra
pull requests added for plone.app.robotframework made me happy you've tackled this issue!
stevepiercy
pushed a commit
that referenced
this pull request
Feb 13, 2024
sneridagh
added a commit
that referenced
this pull request
Feb 15, 2024
…bars-et-al * main: (56 commits) Exclude chromewebstore from linkcheck (#5761) (feat):App extras exceptions (#5621) Add VOLTOCONFIG Env Var (#5752) PoC - Vite and Tanstack Router, Query and `@plone/client` in SSR mode. (#5750) Update links to Redux and React developer extensions for Chrome (#5757) Overhaul environment variables documentation (#5736) Mention what version the 'links and references' view was added (#5756) Add wait commands to flaky block-listing tests (#5753) Fix logging in test-acceptance-server commands (#5748) Replaced outdated diff with a link to the current `package.json` on t… (#5728) Listing Block render of initial results in SSR (#5689) Fix @plone/volto-slate path in moduleNameMapper (#5743) Added global form state. (#5721) Release generate-volto 9.0.0-alpha.5 Fix tests in projects that involves TS files (#5738) Reorganize README, merging content into authoritative locations (#5511) Release 18.0.0-alpha.10 Release generate-volto 9.0.0-alpha.4 Release @plone/registry 1.2.2 Enhance release in @plone/registry ...
|
@davisagli @ichim-david It was like this because of something... I had to remove the tty. I barely recall it, but I think it was something in CI? well, we will find out... Maybe Cypress improved its GHA. |
|
@sneridagh Well, I wondered about that, but the acceptance tests passed, so... ¯_(ツ)_/¯ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start the acceptance image with a pseudo-tty, this fixing a buffering issue where the console output was not shown until exiting.