-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links and references
view via content menu [Add Links to item
view]
#4787
Conversation
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #6365 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so good! I love seeing more docs for the Volto manual. I especially appreciate that the screenshot is narrow and is therefore legible on narrow screens.
Aside from my specific suggestions, for the general docs style, would you please put each sentence is on one line? Then it is good to go.
Thanks for having a look into the docs, @stevepiercy. I incorporated all changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions were not committed, possibly due to merging lines. Please take another look at these. Thank you!
4908541
to
dd7ed64
Compare
Ok, they are all in. Thanks for your hints! I also squashed the last commits, because they all about minor docs fixes. You might want to reset, e.g.: |
This PR needs a Change log entry. Also a couple of jobs fail and need to be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why a few suggestions got dropped, so I went ahead and committed them.
I approve the docs only. A maintainer should review the code. Thank you!
Preview of docs: Finding links to the current item |
49a3c5f
to
5540c43
Compare
@pgrunewald two more jobs are failing, related to code analysis and i18n, the latter of which may have recently changed from another merged PR. Would you please correct these, then request review from a maintainer of Volto? |
@stevepiercy Will do! I think over the weekend i will find some time to fixing these issues. I also added small TODO list in my initial comment. So others get an idea what's still missing. |
This one got missed again. I don't know why. Committing.
Another missed suggestion.
Commit missed suggestion
…released plone.restapi.relations (#4842) Co-authored-by: Steve Piercy <web@stevepiercy.com>
7676a4b
to
d01d316
Compare
Links to item
viewLinks and references
view via content menu [Add Links to item
view]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of MyST syntax improvements and questions
locales/volto.pot
Outdated
@@ -2387,6 +2409,11 @@ msgstr "" | |||
msgid "Origin" | |||
msgstr "" | |||
|
|||
#: components/manage/LinksToItem/LinksToItem | |||
# defaultMessage: Overview and management of relations of all content items |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the addition of this message string require an update to the screen shots?
Is a user truly able to manage relations from this panel, or only look at an overview? If the latter:
# defaultMessage: Overview and management of relations of all content items | |
# defaultMessage: Overview of relations of all content items |
...and update all instances of the message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the addition of this message string require an update to the screen shots?
The button linking to the relations control panel is only for site managers. Therefore I prefer not to mention this in the user documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a user truly able to manage relations from this panel, or only look at an overview?
He/she is indeed able to modify relations. That's the bonus of the new relations control panel. But as the main intent of this content menu addition is about providing a view with the backlinks/references to this page (content item) in text, and not with custom relations, the reduction to 'overview' is fine.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
…s except 'isReferencing')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* master: (42 commits) make selectedView and className props available for Search block (#4997) Release @plone/volto-testing 4.0.0-alpha.0 Release 17.0.0-alpha.21 Upgrade to Cypress 12.17.1 (latest) (#4981) Image rendering (#3337) feat(Url.js): add getFieldURL helper function to get the url value of a field based on its structure (#4731) Handle @linkintegrity response with items but no breaches (#4832) Release 17.0.0-alpha.20 Use all the apiExpanders in use, so we perform a single request for getting all the required data. (#4946) Fix the condition deciding on listing pagination format so it takes into account container blocks as well (#4978) Release 17.0.0-alpha.19 Fix search block input clear button doesn't reset the search (#4837) Add /ok route as an express middleware (#4432) handles condition for yearly frequency in recurrence (#4604) Remove dangling out of place Guillotina Cypress tests (#4980) Update to latest plone.restapi and Plone 6.0.6 (#4979) Update browserlist (#4977) `Links and references` view via content menu [Add `Links to item` view] (#4787) Release 17.0.0-alpha.18 Toc responsive (#4912) ...
…w] (#4787) Co-authored-by: Steve Piercy <web@stevepiercy.com> Co-authored-by: Katja Süss <k.suess@rohberg.ch> Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
Show references to the current content item (backlinks) of
TODO:
[Edit] References (not just links) to item (view and menu item) – Update to released plone.restapi.relations #4842
See the user documentation preview : https://deploy-preview-4787--volto.netlify.app/user-manual/links-to-item.html