Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle @linkintegrity response with items but no breaches #4832

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

davisagli
Copy link
Member

This is in preparation for plone/plone.restapi#1636, which will make a slight change to the response from the @linkintegrity endpoint, so that it's possible for an item to be included in the response even if it doesn't have any potential breaches.

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 9434939
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64b6bc05522481000701c036

@davisagli davisagli requested a review from sneridagh May 30, 2023 01:06
@cypress
Copy link

cypress bot commented May 30, 2023

Passing run #6462 ↗︎

0 7 0 0 Flakiness 0

Details:

Merge branch 'master' into fix-linkintegrity-breaches
Project: Volto Commit: 9434939146
Status: Passed Duration: 02:21 💡
Started: Jul 19, 2023 5:33 AM Ended: Jul 19, 2023 5:35 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sneridagh sneridagh merged commit c9a9127 into master Jul 19, 2023
@sneridagh sneridagh deleted the fix-linkintegrity-breaches branch July 19, 2023 08:38
@sneridagh sneridagh added this to the Plone 6.1 milestone Jul 19, 2023
sneridagh added a commit that referenced this pull request Jul 21, 2023
* master:
  feat(Url.js): add getFieldURL helper function to get the url value of a field based on its structure (#4731)
  Handle @linkintegrity response with items but no breaches (#4832)
sneridagh added a commit that referenced this pull request Jul 23, 2023
Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
sneridagh added a commit that referenced this pull request Jul 23, 2023
)

Co-authored-by: David Glick <david@glicksoftware.com>
sneridagh added a commit that referenced this pull request Jul 24, 2023
* master: (42 commits)
  make selectedView and className props available for Search block (#4997)
  Release @plone/volto-testing 4.0.0-alpha.0
  Release 17.0.0-alpha.21
  Upgrade to Cypress 12.17.1 (latest) (#4981)
  Image rendering (#3337)
  feat(Url.js): add getFieldURL helper function to get the url value of a field based on its structure (#4731)
  Handle @linkintegrity response with items but no breaches (#4832)
  Release 17.0.0-alpha.20
  Use all the apiExpanders in use, so we perform a single request for getting all the required data. (#4946)
  Fix the condition deciding on listing pagination format so it takes into account container blocks as well (#4978)
  Release 17.0.0-alpha.19
  Fix search block input clear button doesn't reset the search (#4837)
  Add /ok route as an express middleware (#4432)
  handles condition for yearly frequency in recurrence (#4604)
  Remove dangling out of place Guillotina Cypress tests (#4980)
  Update to latest plone.restapi and Plone 6.0.6 (#4979)
  Update browserlist (#4977)
  `Links and references` view via content menu [Add `Links to item` view] (#4787)
  Release 17.0.0-alpha.18
  Toc responsive (#4912)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants