-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toc responsive #4912
Toc responsive #4912
Conversation
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is so good, that it should be added to the User Manual. https://6.docs.plone.org/volto/user-manual/blocks.html#table-of-contents-block If possible, please see https://6.docs.plone.org/contributing/documentation/myst-reference.html#width-of-media for how to capture videos. Please and thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. For embedding them, please see our guide on how to make videos usable on all devices.
https://6.docs.plone.org/contributing/documentation/myst-reference.html#video
Also for all media, width is preferred to be at 740 pixels.
https://6.docs.plone.org/contributing/documentation/myst-reference.html#width-of-media
If you are unable to use a smaller size, I will take what I can get. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see one of the videos, docs/source/_static/user-manual/blocks/table-of-contents-block-with-dropdown.mp4
, embedded into https://6.docs.plone.org/volto/user-manual/blocks.html#table-of-contents-block
It looks like the other video demonstrates a bug, but I am not sure.
There are conflicts that need to be resolved in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I have only minor MyST syntax corrections.
Indentation is necessary after the first colon for a definition list definition.
I also added an alt tag for the video.
You can see a preview: https://deploy-preview-4912--volto.netlify.app/user-manual/blocks.html#table-of-contents-block
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve docs only. A core maintainer should review the code. Thank you! This looks great!
Done! |
@sneridagh @MihaelaCretu11 Sorry, I'm messing up again. :-$ I wanted to add a note: I have added @MihaelaCretu11 to Developers, by accident I modify @sneridagh 's comment, and I when I try to revert my comment I've reverted the last commit :-O But I have no clue now how I can revert my accidental revert edit: Ok so apparently my wrong revert only created a new branch, so when we drop that branch everything is fine. |
@fredvd perhaps not through GitHub UI, but try pulling the remote branch down and editing it locally, and so on? |
I have removed branch BTW, there are 514 branches, with some being years old. I am sure lots could be removed. But if this does not bother anyone, we can leave them. |
Co-authored-by: Alin Voinea <contact@avoinea.com> Co-authored-by: Steve Piercy <web@stevepiercy.com>
* master: (42 commits) make selectedView and className props available for Search block (#4997) Release @plone/volto-testing 4.0.0-alpha.0 Release 17.0.0-alpha.21 Upgrade to Cypress 12.17.1 (latest) (#4981) Image rendering (#3337) feat(Url.js): add getFieldURL helper function to get the url value of a field based on its structure (#4731) Handle @linkintegrity response with items but no breaches (#4832) Release 17.0.0-alpha.20 Use all the apiExpanders in use, so we perform a single request for getting all the required data. (#4946) Fix the condition deciding on listing pagination format so it takes into account container blocks as well (#4978) Release 17.0.0-alpha.19 Fix search block input clear button doesn't reset the search (#4837) Add /ok route as an express middleware (#4432) handles condition for yearly frequency in recurrence (#4604) Remove dangling out of place Guillotina Cypress tests (#4980) Update to latest plone.restapi and Plone 6.0.6 (#4979) Update browserlist (#4977) `Links and references` view via content menu [Add `Links to item` view] (#4787) Release 17.0.0-alpha.18 Toc responsive (#4912) ...
No description provided.