-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotly.react #2341
Merged
Merged
Plotly.react #2341
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
54b6969
Plotly.react
alexcjohnson aab4f11
remove flagAxForDelete from _restyle
alexcjohnson 45c56b0
allow 0 in pushUnique
alexcjohnson e58b74d
test Plotly.react with component arrays
alexcjohnson 1074804
_skipSD -> _skipDefaults
alexcjohnson 0548db3
test of polar toggle staticPlot
alexcjohnson 698fa4f
multiline if statements for better debugging
alexcjohnson 3c56243
only add _private attrs to legend after supplyDefaults
alexcjohnson f01bab9
cleanData should modify textposition in place
alexcjohnson 2fbd97c
don't slice uneven arrays in scatter and related traces
alexcjohnson f873b26
stop slicing and generating fake arrays in scatter3d and surface defa…
alexcjohnson 5aaa0df
remove old obsolete exponentformat/showexponent fallback
alexcjohnson 7a3b075
cleaner handling of bin defaults
alexcjohnson 5814642
test_dashboard: highlight the displayed mock in search results
alexcjohnson 8fbe06e
store slider & updatemenu dimensions in _private attrs
alexcjohnson afc05c9
stop slicing data arrays in scattergeo
alexcjohnson 898c39d
hacky handling for reshaped arrays in Plotly.react
alexcjohnson e9270fc
handle transforms in Plotly.react - by looking at _fullInput
alexcjohnson 414a9b8
clean up carpet pushing stuff back to _fullTrace late
alexcjohnson e982ca1
annotatinons3d pdata -> _pdata
alexcjohnson b856ad8
fix for 3d scenes modifying axes range to linear
alexcjohnson 88ad7f2
test a bunch of mocks for noop react redraws
alexcjohnson ade3cca
review comments - :hocho: commented-out code, comment on cleanData
alexcjohnson 4b98be6
fixes for mapbox with Plotly.react
alexcjohnson 3178b2e
update polar for Plotly.react compatibility
alexcjohnson 564dff6
stop filling new [] in pie defaults
alexcjohnson be4932d
fix bugs in rangeslider with explicit range and relayout
alexcjohnson 0752aa5
clean up rangeselector for Plotly.react
alexcjohnson 9ba4be9
update scatterternary for Plotly.react
alexcjohnson 9795b69
avoid NaN in (un)selected.marker.opacity
alexcjohnson 57c7d6c
fix for transformed histograms to give consistent _fullInput
alexcjohnson 3a11062
more complete diffing of config
alexcjohnson 896471c
update scattergeo test
alexcjohnson e12ce1b
wider acceptance range for toimage test
alexcjohnson 46c6642
more complete set of Plotly.react noop mocks to test
alexcjohnson 4197c32
lint
alexcjohnson f9d6151
fix scattergl uneven array handling
alexcjohnson c8a07e8
updated gl3d_ribbons mock
alexcjohnson 2a7d640
reset package-lock to master
alexcjohnson 5d6a4a0
get the right _xlength for surface if x is 2D
alexcjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_xlength
and_ylength
are used in two places, to try and describe how much of each array to use - one insurface/convert
(only for thesurface
type) and again ingl3d/scene
(for all 3d types). The two do things in different ways, and especially since surface can use x/y arrays of either 1 or 2 dimensions, they weren't getting things right. I was trying to do better at handling mismatched arrays but this at least gets it right again for arrays of the correct length (and brings back the originalgl3d_ribbons
mock), and I've added an item for surface to #2353 to explore the mismatched cases more fully.