Skip to content

change plotly.js dependencie by plotly.js-dist #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

FernandezMathieu
Copy link

@FernandezMathieu FernandezMathieu commented Oct 5, 2021

Hi,

This PR refers to this issue : plotly/plotly.js#5966

We are facing trouble to build jupyterlab-plotly because of the box-intersect package in the Plotly.js dependencies which is not accessible through our company CI network.

@archmoj
Copy link
Contributor

archmoj commented Oct 5, 2021

Thanks for the PR.
I also opened #3412 since I was trying to address the issue at the same time.

@nicolaskruchten
Copy link
Contributor

So Plotly.js 2.6 is now out and should be buildable again without needing to connect to Github... Could you please see if your issue is resolved?

@FernandezMathieu
Copy link
Author

So Plotly.js 2.6 is now out and should be buildable again without needing to connect to Github... Could you please see if your issue is resolved?

Yes my issue is resolved. Many thanks to the plotly team, you are great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants