use plotly.js-dist instead of plotly.js

[archmoj]

Supersedes #3411
Addressing: plotly/plotly.js#5966
cc: @FernandezMathieu

[archmoj]

Few tests are failing. I'll let @nicolaskruchten figure them out. Thanks!

[nicolaskruchten]

This approach won't work... the overall code-gen system needs the full build. I can look into this next week or the week after.

[FernandezMathieu]

Hi @nicolaskruchten , will you have time for this PR this week ?

[nicolaskruchten]

I think someone will need to do some deeper engineering here to get the codegen system working with this dependency, or we will have to fix the underlying Plotly.js issue, because we can't merge this PR as-is, and no one on our team is available to dig into the needed work to build the extension using the dist bundle while running the codegen with the full bundle.

[nicolaskruchten]

I'm curious about why you need to build the extension locally as opposed to downloading it from NPM or just letting the plotly.py installation process handle loading the extension?

[FernandezMathieu]

Hi @nicolaskruchten ,

I hear your difficulties with finding time to do this change.
But for companies like mine, using github sources is not compatible with security rules.
Maybe you can just release all dependencies that are uploaded on Github directly on NPM.

For your second message, we use jupyterlab 2, that not include pre-built extension installation.
We are working to upgrade our jupyterlab, meanwhile we are not able to rebuild our production environment.

Maybe we can install pre-built extension on Jupyterlab 2, let me know if i'm wrong here.

[nicolaskruchten]

So Plotly.js 2.6 is now out and should be buildable again without needing to connect to Github... Could you please see if your issue is resolved?

[gvwilson]

@archmoj please let us know if this ought to be in Cycle 16

[gvwilson]

@archmoj can we close this given your recent work? thanks - @gvwilson

[archmoj]

It looks like plotly.py at the moment needs rebuild plot-schema.
So this require extra work.
Closing for now until but we may revisit this.