1.1.0 Release #68

bkchr · 2023-10-19T21:38:22Z

Let's already start with the list of things to include for the 1.1.0 release. Please everyone leave a comment with a link to a pr or issue, so we have it tracked.

I would propose that we directly start with the release after we have finally finished 1.0.0.

The text was updated successfully, but these errors were encountered:

bkontur · 2023-10-19T22:06:11Z

Various backports and alignments with polkadot-sdk (which does not depend on crates.io versions) #45
[ci/cd] Split Test pipeline according to runtime-benchmarks feature #48

joepetrowski · 2023-10-20T05:28:38Z

acatangiu · 2023-10-20T06:40:42Z

bkchr · 2023-11-06T15:34:21Z

I would like that we slowly start with the release. I think the best would be to get @muharem's PR merged first: #56

Probably the best to keep this pr and then create another one that updates to 1.3.0.

franciscoaguirre · 2023-11-08T09:24:08Z

When that PR is merged, I can make one updating to 1.3.0

acatangiu · 2023-11-08T09:43:11Z

When that PR is merged, I can make one updating to 1.3.0

afaik @svyatonik is already working on this: svyatonik#2

muharem · 2023-11-08T10:14:05Z

it would be nice to get this PR to the release #84
I can not base it on #56 since the branch in my fork

will we include polkadot-sdk#1.3 to the this release? @bkchr

bkchr · 2023-11-09T08:46:26Z

will we include polkadot-sdk#1.3 to the this release? @bkchr

As I already said above, I would do it.

muharem · 2023-11-09T13:37:22Z

one more candidate, simple migration removal #54

Sophia-Gold · 2023-11-16T16:13:24Z

Enable async backing on Kusama #90

muharem · 2023-11-30T15:59:53Z

[must have] Fellowship entities get free xcm execution #107
[very nice to have] Fellowship Treasury #109

bkchr · 2023-12-11T10:16:44Z

So, all the prs mentioned above are merged. I still want to include #117 and #118. Maybe also @Leemo94 also wants to bring up his small pr for changing the Kusama OpenGov tracks config. However, I would not wait on this if the pr is not popping up today.

Otherwise we still require a weights update. @ggwpez @liamaharon can you please do this?

bkchr · 2023-12-11T12:56:23Z

#119 this one as well.

NachoPal · 2023-12-11T16:58:49Z

About the weights, I found that this will provoke an Overweight message.

acatangiu · 2023-12-11T17:21:56Z

FWIW: many (if not all) of the required benchmarks have already been run against (relatively) latest main in #108 - you could also get them from there

NachoPal · 2023-12-12T12:10:54Z

Since the introduction of paritytech/polkadot-sdk#1234, the teleport when kicking a member will fail if the AlliancePalletAccount does not have some extra balance to pay the fees.

AlliancePalletAccount (13UVJyLnbVp6r4JgFxb88FAvQBL5WCdE2FU8uzyCJCHkDhx1) should be funded to pay the fees or otherwise it will fail in production.

Similarly will happen with ReferendaPalletAccount (13UVJyLnbVp9974YNNtrNWNjJQhBYSnMoTQycaARVAt49q7h).

joepetrowski · 2023-12-12T13:23:29Z

We are planning to just add an UnpaidTeleport instruction to XCMv4.

bkontur · 2023-12-12T15:22:25Z

About the weights, I found that this will provoke an Overweight message.

@NachoPal Do you have any specific scenario in mind?

Actually, relay chains and system parachains do not recognize any trusted reserves type IsReserve = ();, so they cannot process ReserveAssetDeposited. When we regenerate new benchmarks, then this 500_000_000_000 will become 18_446_744_073_709_551_000 (as a Weight::MAX), this is ok since Gav removed remote weight estimation here. If you want to process ReserveAssetDeposited, you need to set up correct benchmark and IsReserve, e.g. as we did for bridges here.

acatangiu · 2023-12-12T15:52:14Z

What about #108? It's reviewed and ready to merge IMO and only adds functionality that needs further governance actions to actually enable.

It'd be great to get it in this upcoming release!

muharem · 2023-12-12T16:48:31Z

we might want to include this small PR, one constant value change, otherwise the current salary budget limit, might not be enough

Fellowship Salary Budget & Period #121

NachoPal · 2023-12-12T16:57:39Z

StakingAdmin, FellowshipAdmin, etc.. Origins should be waived from paying fees, otherwise it will fail when trying to send xcm messages.

Talked to @muharem and he'll open a PR

bkchr · 2023-12-13T08:56:43Z

What about #108? It's reviewed and ready to merge IMO and only adds functionality that needs further governance actions to actually enable.

It'd be great to get it in this upcoming release!

Still misses reviews.

mustermeiszer · 2023-12-14T10:22:46Z

@bkchr will this also include #67 automatically?

joepetrowski · 2023-12-14T10:23:38Z

Yes

muharem · 2023-12-18T16:31:35Z

Since the introduction of paritytech/polkadot-sdk#1234, the teleport when kicking a member will fail if the AlliancePalletAccount does not have some extra balance to pay the fees.

AlliancePalletAccount (13UVJyLnbVp6r4JgFxb88FAvQBL5WCdE2FU8uzyCJCHkDhx1) should be funded to pay the fees or otherwise it will fail in production.

Similarly will happen with ReferendaPalletAccount (13UVJyLnbVp9974YNNtrNWNjJQhBYSnMoTQycaARVAt49q7h).

fixed with this PR - #125

NachoPal · 2023-12-19T09:17:15Z

StakingAdmin, FellowshipAdmin, etc.. Origins should be waived from paying fees, otherwise it will fail when trying to send xcm messages.

This was fixed also in #125

bkchr · 2023-12-22T15:24:32Z

The following prs are still missing:

@ggwpez

For #68 (comment). Uses instructions introduced to the readme in #127 to re-bench all runtimes. TODO - [x] Is this much change % expected? Is benchmarking on vCPUs flawed because they are arbitrarily shared with other cloud customers? - It seems to be fine, the changes align with actual changes in configuration of the runtimes (thanks @ggwpez!). - [x] Polkadot - [x] Kusama - [x] Asset Hub Polkadot - [x] Asset Hub Kusama - [x] Bridge Hub Polkadot - [x] Bridge Hub Kusama - [x] Collectives Polkadot - [ ] Look into why subweight shows some errors ## Polkadot Changes <img width="1085" alt="Screenshot 2023-12-19 at 11 06 20" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/272e2ecd-48da-4ebb-b6e2-ff9fd73683fe"> <img width="1085" alt="Screenshot 2023-12-19 at 11 08 24" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/a37dea2e-abf6-4ad8-b3ef-abed6cb3e955"> <img width="1085" alt="Screenshot 2023-12-19 at 11 10 14" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/08788059-a052-4af6-b2aa-c791a3cddc24"> ## Kusama Changes <img width="1074" alt="Screenshot 2023-12-19 at 11 12 19" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/b096d1ec-384f-436f-ae9c-f6f929d14b9b"> <img width="1074" alt="Screenshot 2023-12-19 at 11 12 43" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/1bc757e8-c00c-4cf0-bea6-f74b92a33355"> ## Asset Hub Polkadot Changes <img width="1313" alt="Screenshot 2023-12-19 at 20 34 25" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/ea658d57-365d-45de-b0be-2c4627783e64"> ## Asset Hub Kusama Changes <img width="1313" alt="Screenshot 2023-12-19 at 20 43 37" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/963483ee-0d9f-49dc-9a83-31b443df1f10"> ## Bridge Hub Polkadot <img width="1313" alt="Screenshot 2023-12-20 at 11 49 13" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/0da77515-bb36-4a41-9c88-463ea28d9a9e"> ## Bridge Hub Kusama <img width="1313" alt="Screenshot 2023-12-20 at 11 48 39" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/97c7efa4-6a22-42fe-90e0-8477e0628d00"> ## Collectives Polkadot <img width="1369" alt="Screenshot 2023-12-20 at 11 50 33" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/6b2b22f3-fc87-4f19-a126-8d4be2335aa6"> <img width="1369" alt="Screenshot 2023-12-20 at 11 51 07" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/168ec1e2-ec47-4213-8899-f2d51c8ec6d1"> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>

ggwpez · 2024-01-09T13:13:55Z

All ticked off now, can we go ahead?

joepetrowski · 2024-01-09T16:16:50Z

All ticked off now, can we go ahead?

@NachoPal was doing a final run of integration tests. Any ETA on them finishing?

NachoPal · 2024-01-09T18:23:28Z

@NachoPal was doing a final run of integration tests. Any ETA on them finishing?

All green, but spec_versions still need to be bumped.

joepetrowski · 2024-01-09T18:32:28Z

#138

NachoPal · 2024-01-11T11:13:25Z

About the weights, I found that this will provoke an Overweight message.

@NachoPal Do you have any specific scenario in mind?

Actually, relay chains and system parachains do not recognize any trusted reserves type IsReserve = ();, so they cannot process ReserveAssetDeposited. When we regenerate new benchmarks, then this 500_000_000_000 will become 18_446_744_073_709_551_000 (as a Weight::MAX), this is ok since Gav removed remote weight estimation here. If you want to process ReserveAssetDeposited, you need to set up correct benchmark and IsReserve, e.g. as we did for bridges here.

Yes, you are right, that message should fail, but it should fail with an UntrustedReserveLocation and not with an Overweight. It is properly working now.

bkontur · 2024-01-11T11:35:54Z

About the weights, I found that this will provoke an Overweight message.

@NachoPal Do you have any specific scenario in mind?
Actually, relay chains and system parachains do not recognize any trusted reserves type IsReserve = ();, so they cannot process ReserveAssetDeposited. When we regenerate new benchmarks, then this 500_000_000_000 will become 18_446_744_073_709_551_000 (as a Weight::MAX), this is ok since Gav removed remote weight estimation here. If you want to process ReserveAssetDeposited, you need to set up correct benchmark and IsReserve, e.g. as we did for bridges here.

Yes, you are right, that message should fail, but it should fail with an UntrustedReserveLocation and not with an Overweight. It is properly working now.

we had a similar discussions with @acatangiu around here here

hmm, maybe, if we know that IsReserve = () is no-op, than the benchmark should set Weight::zero() instead of T::BlockWeights::get().max_block or Weight::MAX.
But it could be risky, e.g. if we change type IsReseve = ... and forget to regenerate benchmarks...

I don't know, what is the best solution here. Regardless of returned xcm error (WeightNotComputable vs. UntrustedReserveLocation), Weight::MAX seems safer.

bkchr · 2024-01-11T11:39:44Z

Going to close the issue, as the release is finished.

acatangiu mentioned this issue Dec 11, 2023

Removes already applied migrations #118

Merged

bkontur mentioned this issue Dec 13, 2023

XCMv4 paritytech/polkadot-sdk#1230

Merged

4 tasks

liamaharon mentioned this issue Dec 19, 2023

Update Runtime Weights #129

Merged

9 tasks

bkchr closed this as completed Jan 11, 2024

bkontur mentioned this issue Mar 26, 2024

single PR on polkadot-sdk version update #101

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.1.0 Release #68

1.1.0 Release #68

bkchr commented Oct 19, 2023

bkontur commented Oct 19, 2023 •

edited by bkchr

Loading

joepetrowski commented Oct 20, 2023 •

edited

Loading

acatangiu commented Oct 20, 2023 •

edited by bkchr

Loading

bkchr commented Nov 6, 2023

franciscoaguirre commented Nov 8, 2023

acatangiu commented Nov 8, 2023

muharem commented Nov 8, 2023 •

edited

Loading

bkchr commented Nov 9, 2023

muharem commented Nov 9, 2023

Sophia-Gold commented Nov 16, 2023 •

edited

Loading

muharem commented Nov 30, 2023 •

edited by bkchr

Loading

bkchr commented Dec 11, 2023

bkchr commented Dec 11, 2023

NachoPal commented Dec 11, 2023

acatangiu commented Dec 11, 2023 •

edited

Loading

NachoPal commented Dec 12, 2023 •

edited

Loading

joepetrowski commented Dec 12, 2023

bkontur commented Dec 12, 2023

acatangiu commented Dec 12, 2023

muharem commented Dec 12, 2023

NachoPal commented Dec 12, 2023 •

edited

Loading

bkchr commented Dec 13, 2023

mustermeiszer commented Dec 14, 2023

joepetrowski commented Dec 14, 2023

muharem commented Dec 18, 2023

NachoPal commented Dec 19, 2023

bkchr commented Dec 22, 2023 •

edited by ggwpez

Loading

ggwpez commented Jan 9, 2024

joepetrowski commented Jan 9, 2024

NachoPal commented Jan 9, 2024 •

edited

Loading

joepetrowski commented Jan 9, 2024

NachoPal commented Jan 11, 2024 •

edited

Loading

bkontur commented Jan 11, 2024

bkchr commented Jan 11, 2024

1.1.0 Release #68

1.1.0 Release #68

Comments

bkchr commented Oct 19, 2023

bkontur commented Oct 19, 2023 • edited by bkchr Loading

joepetrowski commented Oct 20, 2023 • edited Loading

acatangiu commented Oct 20, 2023 • edited by bkchr Loading

bkchr commented Nov 6, 2023

franciscoaguirre commented Nov 8, 2023

acatangiu commented Nov 8, 2023

muharem commented Nov 8, 2023 • edited Loading

bkchr commented Nov 9, 2023

muharem commented Nov 9, 2023

Sophia-Gold commented Nov 16, 2023 • edited Loading

muharem commented Nov 30, 2023 • edited by bkchr Loading

bkchr commented Dec 11, 2023

bkchr commented Dec 11, 2023

NachoPal commented Dec 11, 2023

acatangiu commented Dec 11, 2023 • edited Loading

NachoPal commented Dec 12, 2023 • edited Loading

joepetrowski commented Dec 12, 2023

bkontur commented Dec 12, 2023

acatangiu commented Dec 12, 2023

muharem commented Dec 12, 2023

NachoPal commented Dec 12, 2023 • edited Loading

bkchr commented Dec 13, 2023

mustermeiszer commented Dec 14, 2023

joepetrowski commented Dec 14, 2023

muharem commented Dec 18, 2023

NachoPal commented Dec 19, 2023

bkchr commented Dec 22, 2023 • edited by ggwpez Loading

ggwpez commented Jan 9, 2024

joepetrowski commented Jan 9, 2024

NachoPal commented Jan 9, 2024 • edited Loading

joepetrowski commented Jan 9, 2024

NachoPal commented Jan 11, 2024 • edited Loading

bkontur commented Jan 11, 2024

bkchr commented Jan 11, 2024

bkontur commented Oct 19, 2023 •

edited by bkchr

Loading

joepetrowski commented Oct 20, 2023 •

edited

Loading

acatangiu commented Oct 20, 2023 •

edited by bkchr

Loading

muharem commented Nov 8, 2023 •

edited

Loading

Sophia-Gold commented Nov 16, 2023 •

edited

Loading

muharem commented Nov 30, 2023 •

edited by bkchr

Loading

acatangiu commented Dec 11, 2023 •

edited

Loading

NachoPal commented Dec 12, 2023 •

edited

Loading

NachoPal commented Dec 12, 2023 •

edited

Loading

bkchr commented Dec 22, 2023 •

edited by ggwpez

Loading

NachoPal commented Jan 9, 2024 •

edited

Loading

NachoPal commented Jan 11, 2024 •

edited

Loading