-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce chain-spec-generator
and document Weight Generation process
#127
Introduce chain-spec-generator
and document Weight Generation process
#127
Conversation
Hi @bkchr, I know that this is temporary tool but in order to create a workaround for zombienet is useful to allow to pass customized plain spec file and get the `raw` one. Thx!
…t-fellows#91) Based on: polkadot-fellows#78 Without this fix we cannot run benchmarks for kusama/polkadot. Tested here: polkadot-fellows#58 (comment)
…or-runtime-benchmarks Add runtime-benchmarks feature to chain spec generator
chain-spec-generator
and document Weight Generation processchain-spec-generator
and document Weight Generation process
@bkontur got back from break today, addressing comments and hope to merge asap. |
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…times into liam-chain-spec-generator
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
With work done in paritytech/polkadot-sdk#2714 the polkadot-sdk generic There is still open question how to handle the rest of chain-spec (e.g. |
Closes #50
chain-spec-generator
from Introduce chain spec generator #78 and Extend chain spec generator for System Parachains #81, updated to work withmaster
.README.md
for generating weights for fellowship runtimesI am currently generating weights and will add them in a seperate PR when they are ready.
TODO
Why not use the
polkadot-sdk
generic chain-spec-builder?The genesis state configs generated by this CLI are unusable for benchmarking, due to poor defaults. We need better defaults for our pallet genesis state before we can use this CLI. See also paritytech/polkadot-sdk#2713.