Extend chain spec generator for System Parachains #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoPal
changed the title
bkchr
reviewed
Nov 3, 2023
|
@bkchr Comments addressed |
pepoviola
approved these changes
Nov 9, 2023
bkontur
reviewed
Nov 10, 2023
|
@NachoPal I just tried benchmarks for kusama on Basti's PR and also @svyatonik maybe has other fixes for system paras? |
I have this: NachoPal#1 :) |
bkontur
approved these changes
Nov 16, 2023
…marks Add runtime-benchmarks feature to chain spec generator
|
Ty! But we also don't need this anymore with the |
2 tasks
bkchr
added a commit
that referenced
this pull request
Jan 17, 2024
…ss (#127) Closes #50 - Adds the `chain-spec-generator` from #78 and #81, updated to work with `master`. - Adds detailed instructions to the `README.md` for generating weights for fellowship runtimes I am currently generating weights and will add them in a seperate PR when they are ready. TODO - [x] Add step for checking weight outputs using https://github.com/ggwpez/substrate-weight-compare in readme - [ ] Fix encointer chain spec defaults, or open new issue for it ### Why not use the `polkadot-sdk` generic chain-spec-builder? The genesis state configs generated by this CLI are unusable for benchmarking, due to poor defaults. We need better defaults for our pallet genesis state before we can use this CLI. See also paritytech/polkadot-sdk#2713. --------- Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Javier Viola <javier@parity.io> Co-authored-by: NachoPal <ignacio.palacios.santos@gmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bkchr Extend chain spec generator #78 for System Parachains