Introduce chain spec generator #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
changed the title
pepoviola
approved these changes
Oct 25, 2023
Hi @bkchr, I know that this is temporary tool but in order to create a workaround for zombienet is useful to allow to pass customized plain spec file and get the `raw` one. Thx!
This was referenced Nov 1, 2023
|
Extension for System Parachains in #81 |
Based on: #78 Without this fix we cannot run benchmarks for kusama/polkadot. Tested here: #58 (comment)
|
This PR and #81 are going to be merged? |
2 tasks
Not really needed anymore with the new chain spec builder runtime api. |
|
Yes! |
2 tasks
bkchr
added a commit
that referenced
this pull request
Jan 17, 2024
…ss (#127) Closes #50 - Adds the `chain-spec-generator` from #78 and #81, updated to work with `master`. - Adds detailed instructions to the `README.md` for generating weights for fellowship runtimes I am currently generating weights and will add them in a seperate PR when they are ready. TODO - [x] Add step for checking weight outputs using https://github.com/ggwpez/substrate-weight-compare in readme - [ ] Fix encointer chain spec defaults, or open new issue for it ### Why not use the `polkadot-sdk` generic chain-spec-builder? The genesis state configs generated by this CLI are unusable for benchmarking, due to poor defaults. We need better defaults for our pallet genesis state before we can use this CLI. See also paritytech/polkadot-sdk#2713. --------- Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Javier Viola <javier@parity.io> Co-authored-by: NachoPal <ignacio.palacios.santos@gmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until paritytech/polkadot-sdk#25 is finished, we need a way to generate a chain spec for the runtimes. This pull request introduces a chain spec generator that can fulfill this task. It currently only supports the relay chain, but can be extended in the future to also support the system chains.
When paritytech/polkadot-sdk#25 is delivered, we can remove the chain spec generator as it will not be required anymore.