Enable Translation of QuestionOption.text (and Refactor Translation of ResearchDomain.label) #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set "integration" as target branch for dependabot
This commit includes needed extra handling in app/models/concerns/exportable_plan.rb. (This file executes .pluck(:text), which prevents us from translating via our overridden text getter method.)
This translation approach is used for every other field specified in config/initializers/translation.rb.
This reverts commit 4fe1918. Commit 43e4a196f7307416862f771c10b34e583f4b5f8a makes this prior code change redundant.
aaronskiba
changed the title
Edit Webmock allowed requests to get chromedriver
…s-tag Add New Google Analytics Tag
This adds the terms and conditions checkbox to the devise invitation form. In addition, `accept_terms` has been added to devise_parameter_sanitizer.permit(). This change is required in order for `accept_terms` to be updated within the update method of Devise::InvitationsController.
This change results in the user being unable to submit the invitation form unless the accept terms checkbox is actually checked. The checkbox handling here is a bit different from the checkbox handling within the create account section of the homepage (see the create method within RegistrationsController). We could do the same here, but it would require a bit more work. Specifically, we'd have to override the Devise::InvitationsController update method within InvitationsController. Also, a bit of extra handling would be required within the DeviseController require_no_authentication method that we are already overriding within InvitationsController.
This change enables app errors to be sent to rollbar.com `config/initializers/rollbar.rb` includes the following line: `config.enabled = false if Rails.env.test?` Thus, having the gem as part of the :default group should be okay. `rake rollbar:test` can be executed to send a test message to rollbar.com. However, this rake task doesn't work when `require: false` is part of the gem 'rollbar' config.
Edit Rollbar Gem To Enable Tracking on rollbar.com
Prior to this commit, all of the templates were simply being sorted by title. Now, the sorting follows the instructions specified within the following GitHub issue comment: #685 (comment)
The `funder.present? && !funder.new_record?` check was being unnecessarily repeated. NOTE: This file features a lot of code exclusive to DMP Assistant. I feel like it could be further cleaned up.
Commit d127444 removed this assignment. However, considering that this instance variable may be used by some corresponding views, this commit puts back the assignment.
Fix Ordering of Templates Within Create Plan Template Dropdown
Add Terms and Conditions For Invitation Form
Merge release `4.0.2+portage-4.0.2` hotfix changes into integration
Merge "integration" into deployment-portage
Bumps [rack](https://github.com/rack/rack) from 2.2.8 to 2.2.9. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@v2.2.8...v2.2.9) --- updated-dependencies: - dependency-name: rack dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
….2.9 Bump rack from 2.2.8 to 2.2.9
`@templates = @templates.uniq` is executed in line 69. Thus, `@templates = @templates.flatten.uniq` would be redundant in line 57.
Handle Ordering of Templates When "No research organization" Box is Checked
Merge "integration" into deployment-portage
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.13 to 6.2.1. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.13...v6.2.1) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…ar-6.2.1 Bump tar from 6.1.13 to 6.2.1
Update CHANGELOG.md for Release 4.0.2+portage-4.0.3
Merge "deployment-portage" into integration
`bundle install` was executed after the Gemfile update.
Update translation gem git: url in Gemfile
Requests to this external API are used for fetching organisations that may not already exist within the local db. At this time, DMP Assistant is limiting organisations to only those that exist within the local db. (New organisations are currently only created manually by DMP super admins).
In order to be executed successfully, the RSpec tests within spec/services/external_apis/ror_service_spec.rb require that Rails.configuration.x.ror.active = true. Regardless of the value of this variable within config/initializers/external_apis/ror.rb, this commit overrides the value to true for the duration of the spec/services/external_apis/ror_service_spec.rb tests.
Deactivate Requests to External ROR API
This commit includes needed extra handling in app/models/concerns/exportable_plan.rb. (This file executes .pluck(:text), which prevents us from translating via our overridden text getter method.)
This translation approach is used for every other field specified in config/initializers/translation.rb.
…roadmap into aaron/issues/537 Rebased
|
Tried rebasing this, but now it's trying to reapply 50+ commits (I think it's because this branch was initially based off of deployment-portage, but we've since created the integration branch.). As a result, #742 has been created and this PR is being closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #537
Changes proposed in this PR: