Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flask-Common not compatible with Flask-1.0 #442

Closed
nateprewitt opened this issue Apr 30, 2018 · 2 comments
Closed

Flask-Common not compatible with Flask-1.0 #442

nateprewitt opened this issue Apr 30, 2018 · 2 comments

Comments

@nateprewitt
Copy link
Contributor

Requests test suit broke a couple hours ago with the release of Flask-1.0. The flask-common module in httpbin relies on the flask.exthook module which was removed, so we now get import errors. We can either update flask-common which seems to have been moved into read-only mode on Github, we pin Flask<1.0, or we can remove it as a dependency.

@kennethreitz do you have any opinion on this? If it's not going to be maintained, I propose we do a one time update to be tolerant of Flask-1.0 changes, and then move to deprecate.
@5j9
Copy link

5j9 commented Apr 30, 2018

BTW, the issue has occurred after Flask-1.0.1 release, Flask-1.0 seems to be OK. See pallets/flask@715a9a3.

@nateprewitt nateprewitt mentioned this issue Apr 30, 2018
Closed
@javabrett
Copy link
Contributor

I suggest pinning to Flask-0.12.2, which is known-compatible and what was used prior to the 1.0/1.0.1 Flask releases. This restores sanity for now and rights the build on master while decisions per above are made.

javabrett added a commit to javabrett/httpbin that referenced this issue May 2, 2018
@javabrett
Locked Flask version to <1.0.0. Temp workaround for postmanlabs#442 w…
a28ed6c 
…hilst compat with Flask 1.0.1 is worked-on.
@javabrett javabrett mentioned this issue May 2, 2018
Closed
javabrett added a commit to javabrett/httpbin that referenced this issue May 5, 2018
@javabrett
Removed Flask-Common. Fixed postmanlabs#442.
662def3
@javabrett javabrett mentioned this issue May 5, 2018
Merged
javabrett added a commit to javabrett/httpbin that referenced this issue May 6, 2018
@javabrett
Removed Flask-Common. Fixed postmanlabs#442.
e987ecf
This was referenced May 6, 2018
Closed
Closed
sigmavirus24 added a commit that referenced this issue May 6, 2018
@sigmavirus24
Merge pull request #447 from javabrett/442-remove-flask-common
7a50a02 
Removed Flask-Common. Fixed #442.
javabrett added a commit to javabrett/httpbin that referenced this issue May 7, 2018
@javabrett
Locked Flask version to <1.0.0. Temp workaround for postmanlabs#442 w…
d4d39db 
…hilst compat with Flask 1.0.1 is worked-on.
virgiliojr94 pushed a commit to virgiliojr94/httpbin-chat2desk that referenced this issue Jul 1, 2023
@javabrett
Removed Flask-Common. Fixed postmanlabs#442.
d773d7a
virgiliojr94 pushed a commit to virgiliojr94/httpbin-chat2desk that referenced this issue Jul 1, 2023
@sigmavirus24
Merge pull request postmanlabs#447 from javabrett/442-remove-flask-co…
e437e2c 
…mmon

Removed Flask-Common. Fixed postmanlabs#442.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@5j9 @javabrett @nateprewitt