Fix problem with missing static/ directory, added Travis config for setup py test #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javabrett
force-pushed
the
travis-setup-py-test
branch
from
5735c88 to
5b6738d
Compare
sigmavirus24
reviewed
Jan 3, 2018
| @@ -8,6 +8,10 @@ matrix: | |||
| env: TOXENV=py27 | |||
| - python: 3.6 | |||
| env: TOXENV=py36 | |||
| - python: 3.6 | |||
| env: TOXENV= | |||
There was a problem hiding this comment.
Is env really necessary here? You're overriding the script below
httpbin/core.py
Outdated
| # https://github.com/kennethreitz/flask-common/issues/7 | ||
| # https://github.com/evansd/whitenoise/issues/166 | ||
| if not os.path.exists('static'): | ||
| os.mkdir('static') |
There was a problem hiding this comment.
This doesn't seem like the right fix. People could run httpbin with a restricted user that cannot make directories or files. In that case, it seems like this is going to be a problem for them. Yes they could just make the directory themselves, but that seems to be lacking.
There was a problem hiding this comment.
yeah let's at least wrap that in a try/except
javabrett
force-pushed
the
travis-setup-py-test
branch
from
5b6738d to
fb9e4ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.