Removed Flask-Common. Fixed #442.

[javabrett]

Fixed #442.

[sigmavirus24]

I don't think we want these. Can you regenerate the Pipfile.lock without them?

[javabrett]

Pipfile.lock was updated via pipenv lock. According to pypa/pipenv#753 (re)generation of host-environment-markers is intended and ongoing.

Is there some switch for pipenv to avoid regeneration, or should pipenv be avoided, or the entries removed by hand, or pypa/pipenv#753 re-raised?

[nateprewitt]

@sigmavirus24, unless it’s been added in the last month or so, I don’t believe there’s any way to disable those.

@javabrett, you’ll want to leave it for now I think. The Pipfile.lock shouldn’t be modified by hand. We’ve typically had a maintainer generate the lockfile to keep some level of consistency. I don’t see a huge reason that’s necessary though, outside of someone else’s system info being stored.

[javabrett]

I could just revert the Pipfile.lock and let a maintainer lock, or feel free to edit my commit for that, then a maintainer can lock.

I am fairly new to pipenv and have been noticing a fair bit of diff churn noise when locking e.g. order of elements.

[javabrett]

I since discovered pypa/pipenv@ecf7842 , and that my pipenv was as-shipped with my CPython and hopelessly out-of-date, so upgraded:

$ which pipenv
/Library/Frameworks/Python.framework/Versions/3.6/bin/pipenv

$ pipenv --version
pipenv, version 8.3.2

$ pip install -U pipenv

$ pipenv --version
pipenv, version 11.10.1

... and pipenv lock no-longer adds that host env.

@sigmavirus24 @nateprewitt please re-review.

[sigmavirus24]

Of note, Flask-common has been unarchived so it could be updated for Flask 1.0, but this is causing direct pain for lots of folks, so I intend to merge this and release it. We can add flask-common back later.