Contingency Load Flow parameters extension #1139
Conversation
vmouradian
force-pushed
the
feature/contingency-parameters-extension
branch
from
09be168 to
dec6e7c
Compare
vmouradian
changed the title
jeandemanged
changed the title
src/main/java/com/powsybl/openloadflow/sa/ContingencyParameters.java
Outdated
Show resolved
Hide resolved
vmouradian
changed the title
There was a problem hiding this comment.
move to a new package com.powsybl.openloadflow.sa.extensions
src/main/java/com/powsybl/openloadflow/sa/ContingencyParameters.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
move to a new package com.powsybl.openloadflow.sa.extensions
There was a problem hiding this comment.
move the new tests to subpackage com.powsybl.openloadflow.sa.extensions
There was a problem hiding this comment.
not sure this class is really useful, just put this code inside the test, also the naming is confusing, JsonSerializer is generic but we can see it is tailored to ContingencyJsonModule. Have a look how it is done in ContingencyJsonTest in powsybl-core.
jeandemanged
changed the title
src/main/java/com/powsybl/openloadflow/sa/ContingencyParametersJsonSerializer.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisProviderTest.java
Outdated
Show resolved
Hide resolved
vmouradian
force-pushed
the
feature/contingency-parameters-extension
branch
from
d47e484 to
69fe35c
Compare
vmouradian
changed the base branch from
main
to
feature/refactor-outer-loops
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
vmouradian
force-pushed
the
feature/contingency-parameters-extension
branch
from
69fe35c to
5a6aa8d
Compare
|
|
|
||
| @Override | ||
| public String getName() { | ||
| return "contingency-parameters"; |
There was a problem hiding this comment.
Adapt it to the new class name
| @@ -0,0 +1,60 @@ | |||
| package com.powsybl.openloadflow.sa.extensions; | |||
| import java.io.IOException; | ||
|
|
||
| @AutoService(ExtensionJsonSerializer.class) | ||
| public class ContingencyLoadFlowParametersJsonSerializer implements ExtensionJsonSerializer<Contingency, ContingencyLoadFlowParameters> { |
There was a problem hiding this comment.
Add docstring with the author's name
|
|
||
| @Override | ||
| public String getExtensionName() { | ||
| return "contingency-parameters"; |
There was a problem hiding this comment.
Adapt it to new class name "contingency-load-flow-parameters"
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Creates the class needed for #1091
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: