ContingencyLoadFlowParameters extension support in Security Analysis #1156

vmouradian · 2024-12-17T13:53:32Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Final part of #1091

Since AIC can be activated only for a contingency, LfNetWorkLoader now needs to always converts the areas.

What is the new behavior (if this is a feature change)?
Uses the class ContingencyLoadFlowParameters created in #1139 in SA calculations

Final part of the work on #1091

Does this PR introduce a breaking change or deprecate an API?

Yes
No

If yes, please check if the following requirements are fulfilled

The Breaking Change or Deprecated label has been added
The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java

jeandemanged

Thank you, I did some cleanup: you forgot to use the AbstractSecurityAnalysis / AcSecurityAnalysis / DcSecurityAnalysis inheritance, making this simpler imho.

But there is some more work needed about outerloop reconfiguration, I wrote a suggestion, let me know what you think.

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

src/main/java/com/powsybl/openloadflow/sa/DcSecurityAnalysis.java

src/test/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImplTest.java

docs/security/parameters.md

jeandemanged · 2025-01-28T21:19:31Z

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

+
+    @Override
+    protected void applyContingencyParameters(AcLoadFlowParameters parameters, ContingencyLoadFlowParameters contingencyParameters, LoadFlowParameters loadFlowParameters, OpenLoadFlowParameters openLoadFlowParameters) {
+        AcOuterLoopConfig outerLoopConfig = AcOuterLoopConfig.findOuterLoopConfig()


a bit worried of calling AcOuterLoopConfig.findOuterLoopConfig() for each contingency, probably some caching has to be implemented (look for memoize in other powsybl places, e.g. in core)

I made a proposal in e45f710, tell me what you think

jeandemanged · 2025-01-28T21:20:04Z

src/main/java/com/powsybl/openloadflow/sa/DcSecurityAnalysis.java

+
+    @Override
+    protected void applyContingencyParameters(DcLoadFlowParameters parameters, ContingencyLoadFlowParameters contingencyParameters, LoadFlowParameters loadFlowParameters, OpenLoadFlowParameters openLoadFlowParameters) {
+        DcOuterLoopConfig outerLoopConfig = DcOuterLoopConfig.findOuterLoopConfig()


same here, probably caching needed for DcOuterLoopConfig.findOuterLoopConfig()

…n to add) Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

sonarqubecloud · 2025-01-31T09:13:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vmouradian self-assigned this Dec 17, 2024

vmouradian changed the title ~~[WIP] Feature : SA : Use Contingency LoadFlow Parameters Extension~~ [WIP] Feature : SA : Reconfigure slack distribution outer loops per contingency using an extension Dec 17, 2024

vmouradian changed the title ~~[WIP] Feature : SA : Reconfigure slack distribution outer loops per contingency using an extension~~ [WIP] Feature : SA : Reconfigure power distribution per contingency using an extension Dec 17, 2024

vmouradian requested a review from m-guibert December 18, 2024 09:54

vmouradian force-pushed the feature/refactor-outer-loops branch from 5d88652 to 1a417ae Compare December 18, 2024 15:13

Base automatically changed from feature/refactor-outer-loops to feature/contingency-parameters-extension December 18, 2024 15:14

vmouradian force-pushed the feature/use-contingency-parameters-extension branch from 69d7eff to b59bda3 Compare December 18, 2024 15:14

vmouradian changed the title ~~[WIP] Feature : SA : Reconfigure power distribution per contingency using an extension~~ [WIP] SA : Reconfigure power distribution per contingency using an extension Dec 18, 2024

vmouradian force-pushed the feature/use-contingency-parameters-extension branch from b59bda3 to 0f157c9 Compare December 18, 2024 16:16

vmouradian force-pushed the feature/contingency-parameters-extension branch from 69fe35c to 5a6aa8d Compare December 18, 2024 16:16

jeandemanged added the Release 03/2025 label Dec 20, 2024

vmouradian force-pushed the feature/use-contingency-parameters-extension branch from 0f157c9 to 6229d23 Compare December 24, 2024 09:23

vmouradian force-pushed the feature/contingency-parameters-extension branch from 3b552cf to 2ed030b Compare January 6, 2025 16:55

vmouradian force-pushed the feature/use-contingency-parameters-extension branch from 6229d23 to 3cf9f83 Compare January 6, 2025 16:55

vmouradian force-pushed the feature/contingency-parameters-extension branch from 2ed030b to aefec28 Compare January 16, 2025 10:40

vmouradian force-pushed the feature/use-contingency-parameters-extension branch from 3cf9f83 to 2bdbabc Compare January 16, 2025 10:49

vmouradian changed the title ~~[WIP] SA : Reconfigure power distribution per contingency using an extension~~ [WIP] SA : Reconfigure power distribution per contingency using ContengencyLoadFlowParameters extension Jan 16, 2025

jeandemanged changed the title ~~[WIP] SA : Reconfigure power distribution per contingency using ContengencyLoadFlowParameters extension~~ [WIP] SA: Reconfigure power distribution per contingency using ContingencyLoadFlowParameters extension Jan 16, 2025

Base automatically changed from feature/contingency-parameters-extension to main January 16, 2025 17:27

vmouradian force-pushed the feature/use-contingency-parameters-extension branch from 2bdbabc to 2b17067 Compare January 16, 2025 18:23

vmouradian changed the title ~~[WIP] SA: Reconfigure power distribution per contingency using ContingencyLoadFlowParameters extension~~ SA: Reconfigure power distribution per contingency using ContingencyLoadFlowParameters extension Jan 16, 2025

vmouradian requested review from m-guibert and removed request for m-guibert January 17, 2025 09:10

m-guibert reviewed Jan 20, 2025

View reviewed changes

src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java Outdated Show resolved Hide resolved

src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java Outdated Show resolved Hide resolved

m-guibert approved these changes Jan 22, 2025

View reviewed changes

jeandemanged changed the title ~~SA: Reconfigure power distribution per contingency using ContingencyLoadFlowParameters extension~~ ContingencyLoadFlowParameters extension support in Security Analysis Jan 22, 2025

jeandemanged requested changes Jan 22, 2025

View reviewed changes

m-guibert mentioned this pull request Jan 23, 2025

LfAction refactoring and area interchange target action support #1172

Open

7 tasks

vmouradian force-pushed the feature/use-contingency-parameters-extension branch from 46fcfc0 to 9ad5082 Compare January 27, 2025 10:25

vmouradian changed the base branch from main to feature/dc-outerloop-name-param January 28, 2025 16:28

vmouradian changed the title ~~ContingencyLoadFlowParameters extension support in Security Analysis~~ [WIP] ContingencyLoadFlowParameters extension support in Security Analysis Jan 28, 2025

jeandemanged requested changes Jan 28, 2025

View reviewed changes

vidaldid-rte force-pushed the feature/dc-outerloop-name-param branch from 05ccafe to 310b99c Compare January 29, 2025 12:36

vmouradian force-pushed the feature/use-contingency-parameters-extension branch from 3f42c3a to b3017c9 Compare January 29, 2025 15:15

Base automatically changed from feature/dc-outerloop-name-param to main January 31, 2025 08:34

vmouradian and others added 20 commits January 31, 2025 10:02

use contingency loadflow parameters extension in SA (some tests remai…

d095b80

…n to add) Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

checkstyle

e980451

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

clean

c99d917

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

fix DC apply of contingency parameters

8fba57f

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

new tests + refactor tests

36748de

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

use new contingency params creation

d8c5fbe

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

refactor contingency lf params reset

59a246a

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

fix

0f42d21

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

enhance test

1b4c6d7

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

doc

1a9daa3

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

simplify

586fe9f

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

clean method signature

9589706

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

javadoc

64f12fc

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

clean / use inheritance

375e331

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>

use outerloop config

c34f082

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

change test

b15654f

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

fix + dc test

7ba516a

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

fix test

bb06c5e

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

cache outerloop config supplier

d676d7e

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

doc

2251959

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>

vmouradian force-pushed the feature/use-contingency-parameters-extension branch from b3017c9 to 2251959 Compare January 31, 2025 09:11

vmouradian changed the title ~~[WIP] ContingencyLoadFlowParameters extension support in Security Analysis~~ ContingencyLoadFlowParameters extension support in Security Analysis Jan 31, 2025

jeandemanged added the ready-for-review label Jan 31, 2025

jeandemanged requested a review from vidaldid-rte January 31, 2025 10:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ContingencyLoadFlowParameters extension support in Security Analysis #1156

ContingencyLoadFlowParameters extension support in Security Analysis #1156

vmouradian commented Dec 17, 2024 •

edited

Loading

jeandemanged left a comment

jeandemanged Jan 28, 2025

vmouradian Jan 29, 2025

jeandemanged Jan 28, 2025

sonarqubecloud bot commented Jan 31, 2025

ContingencyLoadFlowParameters extension support in Security Analysis #1156

Are you sure you want to change the base?

ContingencyLoadFlowParameters extension support in Security Analysis #1156

Conversation

vmouradian commented Dec 17, 2024 • edited Loading

jeandemanged left a comment

Choose a reason for hiding this comment

jeandemanged Jan 28, 2025

Choose a reason for hiding this comment

vmouradian Jan 29, 2025

Choose a reason for hiding this comment

jeandemanged Jan 28, 2025

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 31, 2025

Quality Gate passed

vmouradian commented Dec 17, 2024 •

edited

Loading