Remove iPhone/iPhoneSimulator platform configurations
#6351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
veldrid-spirvpackageRider has finally added automatic detection of runtime identifiers based on the selected device, meaning we don't have to manually choose
iPhone/iPhoneSimulatorwhen deploying to device or a simulator (see thread).This PR makes Apple Silicon machines run with
iossimulator-arm64rather thaniossimulator-x64, hence why ppy/veldrid-spirv#8 is required.Also, iOS build CI should have been failing ever since GitHub switched its macOS runners to arm64, but this was not the case because the iOS projects were incorrectly excluded from the CI. With this change, the iOS projects will be included and the CI will be red until ppy/veldrid-spirv#8 is merged and the package is updated.