Add arm64 simulator target to iOS builds #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
commented
Aug 8, 2024
| @@ -34,7 +34,7 @@ while :; do | |||
| ios) | |||
| _CMakeEnableBitcode=-DENABLE_BITCODE=0 | |||
| _CMakeBuildTarget=veldrid-spirv | |||
| _CMakeGenerator="-G Xcode -T buildsystem=1" | |||
There was a problem hiding this comment.
This argument specifies running the script on Xcode's "legacy build system" which was removed since Xcode 14. The script still generate libraries successfully with the new build system.
frenzibyte
force-pushed
the
iossimulator-arm64
branch
from
c5e003f
to
6a21343
Compare
This reverts commit 6a21343.
No comment.
This was referenced Aug 8, 2024
Matches osu/osu-framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to support builiding our iOS projects with the
iossimulator-arm64target, supposedly avoiding Rosetta emulation and also allowing us to remove the existingiPhone/iPhoneSimulatorplatform configurations thanks to JetBrains Rider's latest updates.Script tested locally on my machine with Xcode 15.4 / iOS 17.5 SDK.
Expected output: