Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Argon" skin gameplay counters to new design #25226

Merged
merged 58 commits into from
Nov 12, 2023

Fix one more reference to removed setting

3e8c89e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Update "Argon" skin gameplay counters to new design #25226

Fix one more reference to removed setting
3e8c89e
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (macOS, MultiThreaded) failed Nov 11, 2023 in 0s

Test Results (macOS, MultiThreaded) ❌

Tests failed

❌ TestResults-macOS-MultiThreaded.trx

5215 tests were completed in 1564s with 5163 passed, 1 failed and 51 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneSkinEditor 9✔️ 1❌ 5s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneSkinEditor

✔️ TestBringToFront(False)
✔️ TestBringToFront(True)
✔️ TestConstructor
✔️ TestCyclicSelection
✔️ TestDragSelection
✔️ TestEditComponent
✔️ TestSendToBack(False)
✔️ TestSendToBack(True)
✔️ TestToggleEditor
❌ TestUndoEditHistory
	TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Current state is same as default: Expected string length 5207 but was 5211. Strings differ at index 5092.
	  Expected: "...Width": 161.5,\n    "Height": 45.0,\n    "Anchor": 36,\n    "..."
	  But was:  "...Width": 161.5,\n    "Height": 44.99994,\n    "Anchor": 36,\n ..."
	  ---------------------------------------------^
	

Annotations

Check failure on line 0 in TestResults-macOS-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Tests.Visual.Gameplay.TestSceneSkinEditor ► TestUndoEditHistory

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Current state is same as default: Expected string length 5207 but was 5211. Strings differ at index 5092.
    Expected: "...Width": 161.5,\n    "Height": 45.0,\n    "Anchor": 36,\n    "..."
    But was:  "...Width": 161.5,\n    "Height": 44.99994,\n    "Anchor": 36,\n ..."
    ---------------------------------------------^
  
Raw output
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Current state is same as default: Expected string length 5207 but was 5211. Strings differ at index 5092.
  Expected: "...Width": 161.5,\n    "Height": 45.0,\n    "Anchor": 36,\n    "..."
  But was:  "...Width": 161.5,\n    "Height": 44.99994,\n    "Anchor": 36,\n ..."
  ---------------------------------------------^

--TearDown
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|66_0()
   at System.Threading.Thread.StartHelper.Callback(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)