Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Argon" skin gameplay counters to new design #25226

Merged
merged 58 commits into from
Nov 12, 2023

Fix one more reference to removed setting

3e8c89e
Select commit
Loading
Failed to load commit list.
Merged

Update "Argon" skin gameplay counters to new design #25226

Fix one more reference to removed setting
3e8c89e
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Nov 11, 2023 in 0s

4 / 4 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Closes #18888 Incomplete
Depends on ppy/osu-resources#292 Completed
Depends on ppy/osu-resources#295 Completed
Depends on resource bump Completed
Depends on #25402 (for size serialisation) Completed
The combo/accuracy counters should probably be set to fixed-width, but I've kept them as-is to match design, leaving it to others for tweaking it. Incomplete
The argon health display's width is slightly less than the component's actual dimensions, due to the little white bar preceding the health bar. Incomplete
The font size specifications are intentionally different from the reference designs. To be specific, they're set to 1.2x the reference specifications, to remain visually matching with the designs (see ppy/osu-framework#3271 & ppy/osu-framework#5123). Incomplete
The glyph scale factors has been tweaked to match the reference design at 1x drawable scale (settling at 0.125x). Incomplete
I've intentionally exposed ArgonWedgePiece to allow for users to utilise the wedges in their custom "Argon" skins, seeing that there's no harm in doing so. Incomplete