Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change non-legacy control points to have CustomSampleBank 1 #29311

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Refactor if/else as ternary conditional

18dc375
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Change non-legacy control points to have CustomSampleBank 1 #29311

Refactor if/else as ternary conditional
18dc375
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Linux, SingleThread) failed Aug 20, 2024 in 1s

10353 passed, 1 failed and 74 skipped

Tests failed

❌ TestResults-Linux-SingleThread.trx

10428 tests were completed in 1875s with 10353 passed, 1 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Multiplayer.TestSceneDrawableRoomPlaylist 31✅ 1❌ 4s

❌ osu.Game.Tests.Visual.Multiplayer.TestSceneDrawableRoomPlaylist

✅ TestConstructor
✅ TestConstructor
✅ TestDownloadButtonHiddenWhenBeatmapExists
✅ TestDownloadButtonHiddenWhenBeatmapExists
✅ TestDownloadButtonVisibleInitiallyWhenBeatmapDoesNotExist
✅ TestDownloadButtonVisibleInitiallyWhenBeatmapDoesNotExist
✅ TestEditable
✅ TestEditable
✅ TestEditableSelectable
✅ TestEditableSelectable
✅ TestExpiredItems
✅ TestExpiredItems
✅ TestExplicitBeatmapItem
✅ TestExplicitBeatmapItem
✅ TestKeyboardSelection
✅ TestKeyboardSelection
✅ TestMarkInvalid
✅ TestMarkInvalid
✅ TestNonEditableNonSelectable
✅ TestNonEditableNonSelectable
✅ TestSelectable
✅ TestSelectable
❌ TestSelectableMouseHandling
	System.InvalidOperationException : Sequence contains no elements
✅ TestSelectableMouseHandling
✅ TestSelectionNotLostAfterRearrangement
✅ TestSelectionNotLostAfterRearrangement
✅ TestWithAllButtonsEnabled
✅ TestWithAllButtonsEnabled
✅ TestWithOwner(False)
✅ TestWithOwner(False)
✅ TestWithOwner(True)
✅ TestWithOwner(True)

Annotations

Check failure on line 324 in osu.Game.Tests/Visual/Multiplayer/TestSceneDrawableRoomPlaylist.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Linux, SingleThread)

osu.Game.Tests.Visual.Multiplayer.TestSceneDrawableRoomPlaylist ► TestSelectableMouseHandling

Failed test found in:
  TestResults-Linux-SingleThread.trx
Error:
  System.InvalidOperationException : Sequence contains no elements
Raw output
System.InvalidOperationException : Sequence contains no elements
   at System.Linq.ThrowHelper.ThrowNoElementsException()
   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source)
   at osu.Game.Tests.Visual.Multiplayer.TestSceneDrawableRoomPlaylist.<>c__DisplayClass16_0.<TestSelectableMouseHandling>b__3() in /home/runner/work/osu/osu/osu.Game.Tests/Visual/Multiplayer/TestSceneDrawableRoomPlaylist.cs:line 324
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.<.ctor>b__1_0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /home/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)