Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 81: Support rolling upgrades #124

Merged
merged 32 commits into from
Apr 5, 2019
Merged

Issue 81: Support rolling upgrades #124

merged 32 commits into from
Apr 5, 2019

Conversation

adrianmo
Copy link
Contributor

@adrianmo adrianmo commented Jan 30, 2019 •
edited
Loading

Change log description

  • Controller: implement cluster upgrade (upgrade process is described in doc/cluster_upgrade.md)
  • Controller: apply configuration based on the Pravega version (e.g., useHostNameAsBookieID=false version < 0.5)
  • API: add new spec.version field. Updating this field will trigger an upgrade.
  • API: deprecate the use of .spec.Pravega.Image.Tag and .spec.Bookkeeper.Image.Tag to set Pravega and Bookkeeper versions. Should use .spec.Version instead, which will be used as a tag to pull images for Pravega and BookKeepre.
  • API: changes to the API are backwards compatible
  • Cluster Status: add desired version information (null when no upgrade is in progress)
  • Cluster Status: add Upgrade and Error conditions
  • E2E tests: add test case to validate upgrade process
  • Unit tests: add test cases to check version configuration
  • Unit tests: refactor operator controller tests
  • Documentation: add information about scaling a cluster
  • Documentation: create an upgrade page in doc/cluster_upgrade.md
  • Documentation: move troubleshooting information from the readme to a dedicated page indoc/troubleshooting.md

Purpose of the change

Fix #81

How to test the change

An end-to-end test case has been added to validate the upgrade process. Tests should pass.

Signed-off-by: Adrián Moreno adrian@morenomartinez.com

@adrianmo
Mark checkbox in README file
38b8ab5 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo adrianmo added status/work-in-progress PR work is in progress; do not merge kind/feature New feature labels Jan 30, 2019
@adrianmo adrianmo self-assigned this Jan 30, 2019
@adrianmo
Copy link
Contributor Author

Operator: Support Pravega upgrades

@adrianmo
Update API spec to unify version to use
920a271 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
WiP
6cb1be6 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Merge branch 'master' into issue-81-upgrade-feature
6711ced 
* master:
  Issue 10: Update cluster status (#123)
@adrianmo
Create upgrade framework
64f76fc 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
upgrade framework updates
9c7cf6b 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Implement upgrade process for Controller and SegmentStore
ec02d90 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
BK upgrade logic
dddda57 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Merge branch 'master' into issue-81-upgrade-feature
ea006bd 
* master:
  Issue 64: configure bookie metrics (#122)
  Issue 106: Updating README.md (#108)
@adrianmo
BK upgrade
bd8a2a7 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Merge branch 'master' into issue-81-upgrade-feature
f375f29 
* master:
  Issue 130: Ability to specify container resources (#129)
  Issue 134,137: Fix BookKeeper errors (#135)
  Run tests on GKE (#140)
  Document update: README.md (#133)
  Add service account role definitions [skip ci] (#136)
@adrianmo
Fix merge issues
4870b6b 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Wip
c358063 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Merge branch 'master' into issue-81-upgrade-feature
9160c46 
* master:
  Fix Pravega and BookKeeper Java options (#145)
@adrianmo
WiP
31df3ae 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Normlize cluster version
ded3d9a 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Merge branch 'master' into issue-81-upgrade-feature
6e3b930 
* master:
  Fix cr-detailed (#149)
@adrianmo adrianmo changed the title [WiP] Issue 81: Support rolling upgrades Issue 81: Support rolling upgrades Apr 1, 2019
@adrianmo
Re-enable other e2e tests
b4772cd 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Set default version if not set
9648da5 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
dont upgrade if pods are not ready
0cba0cb 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Add unit tests
cadcf45 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Update README with upgrade and scale information
3febbf6 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Add labels to SS and CC
567dd40 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo adrianmo added status/ready The issue is ready to be worked on; or the PR is ready to review and removed status/work-in-progress PR work is in progress; do not merge labels Apr 1, 2019
@adrianmo
Copy link
Contributor Author

adrianmo commented Apr 1, 2019

@Tristan1900 can you please have a look at the PR? Thanks!

@adrianmo
Remove commented lines
66c596f 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Draft of upgrade guide
991188b 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Update documentation
e153f2b 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Add upgrade scope section
9770f91 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@Tristan1900
Copy link
Member

@adrianmo Thanks for updating the doc! LGTM.

@adrianmo
Make API change backwards compatible
0d875c3 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Copy link
Contributor Author

adrianmo commented Apr 4, 2019

@Tristan1900 I'm re-requesting a review from you after the recent changes made to the PR. Thank you!

@adrianmo
Update API clients
c098ad8 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Increase upgrade timeout
f98a80a 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Merge create and recreate e2e test cases
67bc4ec 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Changes on image tag
1593fa1 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo adrianmo merged commit 67c9851 into master Apr 5, 2019
@adrianmo adrianmo deleted the issue-81-upgrade-feature branch April 5, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tristan1900 Tristan1900 Tristan1900 approved these changes

Assignees

@adrianmo adrianmo

Labels
kind/feature New feature status/ready The issue is ready to be worked on; or the PR is ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianmo @Tristan1900