Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bidObj.size is miss calculated for bid the object in the sovrn adaptor #110

Closed
pdramos1 opened this issue Nov 19, 2015 · 2 comments
Closed

bidObj.size is miss calculated for bid the object in the sovrn adaptor #110

pdramos1 opened this issue Nov 19, 2015 · 2 comments
Labels
bug

Comments

@pdramos1
Copy link
Collaborator

the bidobj is calculated incorrectly.
bid.width = bidObj.sizes[0][0];
bid.height = bidObj.sizes[0][1];

So when renderAd is called the width and height are undefined.. and the iframe does not get sized correctly.
@mkendall07
Copy link
Member

Hey @pdramos1

Is the fix ready to be merged for this?

@pdramos1
Copy link
Collaborator Author

crap.. got totally pulled in 80 directions..
let me do the pull request.

On Tue, Nov 24, 2015 at 10:06 AM, mkendall notifications@github.com wrote:

Hey @pdramos1 https://github.com/pdramos1

Is the fix ready to be merged for this?

—
Reply to this email directly or view it on GitHub
#110 (comment).

@mkendall07 mkendall07 added the bug label Dec 2, 2015
vzhukovsky added a commit to aol/Prebid.js that referenced this issue Sep 6, 2017
@vzhukovsky
Merge pull request prebid#110 in AOLP_ADS_JS/prebid.js from release/1…
711ffb3 
….24.0 to aolgithub-master

* commit '7a81386579a3c129617323ef32e1c8be0897c3c7': (31 commits)
  Added changelog entry.
  Added records in aolPartnersIds.json.
  Prebid 0.25.0 Release
  Added Unruly adapter (prebid#1264)
  Fixing Adyoulike adapter for Safari iOS7 (prebid#1296)
  hide overflow to prevent scrolling (prebid#1294)
  fix protocol detection in iframe (prebid#1293)
  Add eplanning adapter (prebid#1245)
  Use Renderer command queue to render outstream (prebid#1283)
  Generate no-bid response for ech bid request not matched by a bid (prebid#1216)
  New Cox adapter (prebid#1228)
  Carambola Adapter (prebid#1221)
  Pass through transactionId and set fd=1 (prebid#1259)
  Integration test page for adapters (prebid#1182)
  Getting DigiTrustID in GumGum adapter (prebid#1256)
  Trion adapter (prebid#1254)
  use request bidder code as default bidderCode for createBid (prebid#1235)
  Add drop pixels once feature to AOL Adapter (prebid#1224)
  Rubicon Adapter - Adding 320x150 (prebid#1279)
  Prevent 'about:' protocol in _publisherTagUrl (prebid#1170)
  ...
github-baptiste-haudegand pushed a commit to ebuzzing/Prebid.js that referenced this issue May 21, 2024
@github-christophe-oudar @github-baptiste-haudegand
bump node to run build scripts (prebid#110)
cf7f51c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkendall07 @pdramos1