Use Renderer command queue to render outstream #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Jun 13, 2017
src/adapters/appnexusAst.js
Outdated
| // setup code for renderer, if any | ||
| function onOutstreamRendererLoaded(bid) { | ||
| // adload.loadScript has loaded ANOutstreamVideo | ||
| bid.renderer.loaded = true; |
There was a problem hiding this comment.
Should we do this automatically in the renderer? Not have the caller manage it?
There was a problem hiding this comment.
Really everything in this method is common, so we can abstract it away and not need it to be defined in the adapter.
There was a problem hiding this comment.
Added a commit to do this. Bidders can override the callback by passing a function on the callback property given to Renderer.install. If that's unnecessary or other changes needed, will update
mkendall07
approved these changes
Jun 13, 2017
Yann-Pravo
pushed a commit
to Yann-Pravo/Prebid.js
that referenced
this pull request
Jul 6, 2017
* Use Renderer command queue to render outstream * Abstract automatic processing in renderer
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Sep 6, 2017
….24.0 to aolgithub-master * commit '7a81386579a3c129617323ef32e1c8be0897c3c7': (31 commits) Added changelog entry. Added records in aolPartnersIds.json. Prebid 0.25.0 Release Added Unruly adapter (prebid#1264) Fixing Adyoulike adapter for Safari iOS7 (prebid#1296) hide overflow to prevent scrolling (prebid#1294) fix protocol detection in iframe (prebid#1293) Add eplanning adapter (prebid#1245) Use Renderer command queue to render outstream (prebid#1283) Generate no-bid response for ech bid request not matched by a bid (prebid#1216) New Cox adapter (prebid#1228) Carambola Adapter (prebid#1221) Pass through transactionId and set fd=1 (prebid#1259) Integration test page for adapters (prebid#1182) Getting DigiTrustID in GumGum adapter (prebid#1256) Trion adapter (prebid#1254) use request bidder code as default bidderCode for createBid (prebid#1235) Add drop pixels once feature to AOL Adapter (prebid#1224) Rubicon Adapter - Adding 320x150 (prebid#1279) Prevent 'about:' protocol in _publisherTagUrl (prebid#1170) ...
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
* Use Renderer command queue to render outstream * Abstract automatic processing in renderer
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Use Renderer command queue to render outstream * Abstract automatic processing in renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR adds properties to the Renderer constructor that can be used to delay rendering until a renderer is loaded.
appnexusAstthen makes use of these capabilities to enable rendering outstream video without the need for an ad server.A call to
pbjs.renderAdwith a winning outstream bid can potentially be invoked before the render function for this bid is in memory. In this case, the render function pushes to the render command queue, which then gets processed after the renderer is loaded. Calls torenderer.render(bid)after the renderer is loaded will skip the command queue and invoke the render function immediately.As a result, outstream video rendering that is invoked with an ad server, and outstream video rendering that is invoked without an adserver, will both work.