Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test page for adapters #1182

Merged
merged 4 commits into from
Jun 9, 2017

Conversation

dbemiller
Copy link
Contributor

Type of change

  • Other (documentation)

Description of change

Adding a "hello world" page which can be used to test adapter PRs. The goal here is to prevent the need for comments like these:

@dbemiller dbemiller changed the title Improvement/simple adapter test Integration test page for adapters May 5, 2017
@dbemiller
Copy link
Contributor Author

Also: If anyone wants to tell me which integrationExamples they don't find any value in anymore, I'm happy to delete them here.

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@matthewlane matthewlane merged commit b680317 into master Jun 9, 2017
@matthewlane matthewlane deleted the improvement/simple-adapter-test branch June 9, 2017 22:20
@dbemiller dbemiller mentioned this pull request Jun 13, 2017
9 tasks
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Sep 6, 2017
….24.0 to aolgithub-master

* commit '7a81386579a3c129617323ef32e1c8be0897c3c7': (31 commits)
  Added changelog entry.
  Added records in aolPartnersIds.json.
  Prebid 0.25.0 Release
  Added Unruly adapter (prebid#1264)
  Fixing Adyoulike adapter for Safari iOS7 (prebid#1296)
  hide overflow to prevent scrolling (prebid#1294)
  fix protocol detection in iframe (prebid#1293)
  Add eplanning adapter (prebid#1245)
  Use Renderer command queue to render outstream (prebid#1283)
  Generate no-bid response for ech bid request not matched by a bid (prebid#1216)
  New Cox adapter (prebid#1228)
  Carambola Adapter (prebid#1221)
  Pass through transactionId and set fd=1 (prebid#1259)
  Integration test page for adapters (prebid#1182)
  Getting DigiTrustID in GumGum adapter (prebid#1256)
  Trion adapter (prebid#1254)
  use request bidder code as default bidderCode for createBid (prebid#1235)
  Add drop pixels once feature to AOL Adapter (prebid#1224)
  Rubicon Adapter - Adding 320x150 (prebid#1279)
  Prevent 'about:' protocol in _publisherTagUrl (prebid#1170)
  ...
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017
* Added a hello world example page for testing new adapter submissions.

* Added a line to the README which (hopefully) will point adapter PRs to the new test page.

* Updated the github PR template.
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Added a hello world example page for testing new adapter submissions.

* Added a line to the README which (hopefully) will point adapter PRs to the new test page.

* Updated the github PR template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants