-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test page for adapters #1182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbemiller
changed the title
Improvement/simple adapter test
Integration test page for adapters
May 5, 2017
Also: If anyone wants to tell me which |
jaiminpanchal27
approved these changes
Jun 8, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
matthewlane
approved these changes
Jun 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Sep 6, 2017
….24.0 to aolgithub-master * commit '7a81386579a3c129617323ef32e1c8be0897c3c7': (31 commits) Added changelog entry. Added records in aolPartnersIds.json. Prebid 0.25.0 Release Added Unruly adapter (prebid#1264) Fixing Adyoulike adapter for Safari iOS7 (prebid#1296) hide overflow to prevent scrolling (prebid#1294) fix protocol detection in iframe (prebid#1293) Add eplanning adapter (prebid#1245) Use Renderer command queue to render outstream (prebid#1283) Generate no-bid response for ech bid request not matched by a bid (prebid#1216) New Cox adapter (prebid#1228) Carambola Adapter (prebid#1221) Pass through transactionId and set fd=1 (prebid#1259) Integration test page for adapters (prebid#1182) Getting DigiTrustID in GumGum adapter (prebid#1256) Trion adapter (prebid#1254) use request bidder code as default bidderCode for createBid (prebid#1235) Add drop pixels once feature to AOL Adapter (prebid#1224) Rubicon Adapter - Adding 320x150 (prebid#1279) Prevent 'about:' protocol in _publisherTagUrl (prebid#1170) ...
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
* Added a hello world example page for testing new adapter submissions. * Added a line to the README which (hopefully) will point adapter PRs to the new test page. * Updated the github PR template.
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Added a hello world example page for testing new adapter submissions. * Added a line to the README which (hopefully) will point adapter PRs to the new test page. * Updated the github PR template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adding a "hello world" page which can be used to test adapter PRs. The goal here is to prevent the need for comments like these: