Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bidmanager times out before saving last bid #1298

Closed
kitwestneat opened this issue Jun 15, 2017 · 1 comment
Closed

bidmanager times out before saving last bid #1298

kitwestneat opened this issue Jun 15, 2017 · 1 comment
Assignees
@mkendall07 @jaiminpanchal27
Labels
bug Prebid 1.0

Comments

@kitwestneat
Copy link
Contributor

Type of issue

bug

Description

When prebid receives a bid after the timeout, it executes the callbacks before saving the bid. This has the effect of ignoring the bid for those who rely on callbacks.

Steps to reproduce

It's easy to reproduce if you put a breakpoint right before the responseTimestamp is set.

Expected results

All bids, including the one that triggered the timeout, are added to bids received when the callbacks are called.

Actual results

The last bid is ignored.
@kitwestneat kitwestneat mentioned this issue Jun 15, 2017
Closed
2 tasks
@mkendall07
Copy link
Member

@kitwestneat we will fix this as part of prebid 1.0

mkendall07 added a commit that referenced this issue Sep 13, 2017
@mkendall07
closes #1298
7441fc8
@ghost ghost assigned mkendall07 Sep 13, 2017
@ghost ghost added in progress and removed ready labels Sep 13, 2017
@ghost ghost removed the in progress label Sep 19, 2017
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this issue Sep 21, 2017
@jbAdyoulike
closes prebid#1298 (prebid#1583)
1e64428
outoftime pushed a commit to Genius/Prebid.js that referenced this issue Sep 21, 2017
Merge tag '0.29.0' of https://github.com/prebid/Prebid.js into prebuilt
3fdf977 
* tag '0.29.0' of https://github.com/prebid/Prebid.js: (29 commits)
  Prebid 0.29.0 Release
  Fix for not syncing bidders.  (prebid#1598)
  fix amp example pages (prebid#1597)
  closes prebid#1298 (prebid#1583)
  Fixed the broken tests. (prebid#1602)
  Rubicon Bidder Factory (prebid#1587)
  Trustx adapter (prebid#1488)
  Add nurl to markup (prebid#1601)
  Pass bidRequest to createBid (prebid#1600)
  Add Kumma adapter (prebid#1512)
  Serverbid alias (prebid#1560)
  Add user sync to process for approving adapter PRs (prebid#1457)
  fix travis build (prebid#1595)
  Rubicon project improvement/user sync (prebid#1549)
  Adding Orbitsoft adapter (prebid#1378)
  Fix renderer test for new validation rule (prebid#1592)
  Allow SET_TARGETING to be used in AnalyticsAdapter (prebid#1577)
  Add support for video stream context (prebid#1483)
  Invalidate bid if matching bid request not found (prebid#1575)
  allow adapters to set default adserverTargeting for specific bid (prebid#1568)
  ...
vzhukovsky added a commit to aol/Prebid.js that referenced this issue Oct 13, 2017
@vzhukovsky
Merge pull request prebid#125 in AOLP_ADS_JS/prebid.js from release/1…
02899e5 
….29.0 to aolgithub-master

* commit 'd7a1d285acbf95fad7562f1c0077ea99df9e5976': (45 commits)
  Added changelog entry.
  Add support for secure bid requests for one mobile get endpoint.
  Fixed adding undefined value for request without data
  Fixed wrong userSyncs type for image tags
  Updated unit tests for AOL userSyncOn.
  Added support for dropping pixels after bid response.
  Improved code formatting, fixed typos.
  Added userSync feature for aol adapter.
  Added test cases for contentType and headers. Fixes unit tests for AOL adapter.
  Added cpm adjustment warning.
  Added initial support for unit tests.
  Added drop pixels support.
  Added bid response handler.
  Converted AOL bid adapter to Prebid 1.0.
  Added changelog entry.
  Added new aol partners ids.
  Prebid 0.29.0 Release
  Fix for not syncing bidders.  (prebid#1598)
  fix amp example pages (prebid#1597)
  closes prebid#1298 (prebid#1583)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this issue Jul 17, 2018
@dluxemburg
closes prebid#1298 (prebid#1583)
fbf7eff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkendall07 mkendall07

@jaiminpanchal27 jaiminpanchal27

Labels
bug Prebid 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Last bid timeout kitwestneat/Prebid.js
4 participants
@kitwestneat @matthewlane @mkendall07 @jaiminpanchal27