Adding Orbitsoft adapter #1378

Indra-sensei · 2017-07-13T08:04:49Z

Type of change

New bidder adapter

Description of change

New Orbitsoft bidder

test parameters for validating bids

{
  bidder: 'orbitsoft',
  params: {
    placementId: '142',
    requestUrl: '//adserver.com/ads/show/hb' // Url to perform search request
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
support@orbitsoft.com
official adapter submission

Other information

snapwich · 2017-07-19T21:36:32Z

modules/orbitsoftBidAdapter.js

+    let bids = params.bids || [];
+
+    if (bids.length === 0) {
+      return;


this conditional is kind of pointless. if bids.length === 0 then the for loop below won't iterate and the function will return anyways

snapwich · 2017-07-19T21:38:11Z

modules/orbitsoftBidAdapter.js

+      // @if NODE_ENV='debug'
+      utils.logMessage('No param requestUrl');
+      // @endif
+      return null;


If there are errors creating the bid request, you should return a NO_BID to prebid

Fixed (on line 47)

snapwich · 2017-07-19T21:46:34Z

test/spec/modules/orbitsoftBidAdapter_spec.js

+        cpm: 0
+      };
+
+      pbjs._bidsRequested.push(bidderRequest);


Shouldn't need to mess with Prebid's private vars. This has the ability to affect other tests, plus it's a private var so it could possible it could change.

But this is done by push method, which not has affect other tests, and this is exactly what is recommended by the official document at http://prebid.org/dev-docs/testing-prebid.html
And this technique is used for most other adapter tests for prebid.js

mkendall07 · 2017-09-13T02:24:10Z

@snapwich what's the status on this?

snapwich · 2017-09-13T16:06:32Z

modules/orbitsoftBidAdapter.js

+    callBids: baseAdapter.callBids,
+    setBidderCode: baseAdapter.setBidderCode,
+    buildJPTCall: buildJPTCall
+  };


In order for your adapter to be alias-able the .constructor reference on your adapter instances needs to point to the correct constructor function; by returning a new object that reference will be incorrect.

You can solve this with:

return Obect.assign(this, { callBids: baseAdapter.callBids, setBidderCode: baseAdapter.setBidderCode, buildJPTCall: buildJPTCall });

@snapwich Fixed

Sorry, you need to modify it to be the way I described (return this). You can look at another adapter if you wish to get an example, but the modifications you made look like the old alias pattern. createNew is no longer needed, but the constructor functions must return a reference to this.

@snapwich Sorry for this. I made changes.

mkendall07 · 2017-09-15T11:59:05Z

modules/orbitsoftBidAdapter.js

+};
+
+adaptermanager.registerBidAdapter(new OrbitsoftAdapter(), ORBITSOFT_BIDDERCODE);
+adaptermanager.aliasBidAdapter('orbitsoft', 'orbitadserving');


why so many aliases?

@mkendall07 We rebranded recently from Orbitscripts with Orbit Ad Serving product to Orbitsoft.
If too much, I can delete.

I think it is a bit confusing to have so many. Typically if the code changes we put the alias in to help with transition but since this is a new adapter I don't think you need them. You should use your current preferred name only.

@mkendall07 It is fair remark. Deleted it.

mkendall07 · 2017-09-15T12:36:50Z

modules/orbitsoftBidAdapter.js

+    for (let i = 0; i < bids.length; i++) {
+      let bidRequest = bids[i];
+      let callbackId = bidRequest.bidId;
+      let jptCall = buildJPTCall(bidRequest, callbackId);


I see you are hitting the AppNexus endpoint. Is there a reason you cannot use an AppNexus alias instead of creating your own adapter?

@mkendall07 AppNexus has built-in enpoint URL for bid requesting. Our adapter sends bid request to various endpoint URL where customers install our product. Endpoint URL is defined by the requestUrl parameter and different for diffrent customers.
We also have additional options for requesting bids and ads.

mkendall07

LGTM

…built * 'master' of https://github.com/prebid/Prebid.js: (46 commits) Serverbid alias (prebid#1560) Add user sync to process for approving adapter PRs (prebid#1457) fix travis build (prebid#1595) Rubicon project improvement/user sync (prebid#1549) Adding Orbitsoft adapter (prebid#1378) Fix renderer test for new validation rule (prebid#1592) Allow SET_TARGETING to be used in AnalyticsAdapter (prebid#1577) Add support for video stream context (prebid#1483) Invalidate bid if matching bid request not found (prebid#1575) allow adapters to set default adserverTargeting for specific bid (prebid#1568) Custom granularity precision should honor 0 if it is passed in closes prebid#1479 (prebid#1591) BaseAdapter for the Prebid 0.x -> 1.x transition (prebid#1494) Add a version to the Criteo adapter (prebid#1573) Allow bundling from node.js or with new gulp task bundle-to-stdout (prebid#1570) Add url.parse option to not decode the whole URL (prebid#1480) Tremor Video Bid Adapter (prebid#1552) Yieldmo bid adapter (prebid#1415) Switch `gulp docs` to build its output using documentation.js (prebid#1545) Increment pre version Prebid 0.28.0 Release ...

* Adding Orbitsoft module * Adding Orbitsoft module (corrected) * Adding Orbitsoft module (correction of remarks) * Adding Orbitsoft module (correction of remarks) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to new constructor) * Adding Orbitsoft module (delete unnecessary aliases) * Adding Orbitsoft module (delete unnecessary aliases)

* tag '0.29.0' of https://github.com/prebid/Prebid.js: (29 commits) Prebid 0.29.0 Release Fix for not syncing bidders. (prebid#1598) fix amp example pages (prebid#1597) closes prebid#1298 (prebid#1583) Fixed the broken tests. (prebid#1602) Rubicon Bidder Factory (prebid#1587) Trustx adapter (prebid#1488) Add nurl to markup (prebid#1601) Pass bidRequest to createBid (prebid#1600) Add Kumma adapter (prebid#1512) Serverbid alias (prebid#1560) Add user sync to process for approving adapter PRs (prebid#1457) fix travis build (prebid#1595) Rubicon project improvement/user sync (prebid#1549) Adding Orbitsoft adapter (prebid#1378) Fix renderer test for new validation rule (prebid#1592) Allow SET_TARGETING to be used in AnalyticsAdapter (prebid#1577) Add support for video stream context (prebid#1483) Invalidate bid if matching bid request not found (prebid#1575) allow adapters to set default adserverTargeting for specific bid (prebid#1568) ...

* Adding Orbitsoft module * Adding Orbitsoft module (corrected) * Adding Orbitsoft module (correction of remarks) * Adding Orbitsoft module (correction of remarks) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to new constructor) * Adding Orbitsoft module (delete unnecessary aliases) * Adding Orbitsoft module (delete unnecessary aliases)

dmitriy-shimko-nrich added 2 commits July 13, 2017 09:51

Adding Orbitsoft module

82686c9

Adding Orbitsoft module (corrected)

d068d59

matthewlane added the needs review label Jul 13, 2017

matthewlane assigned ndhimehta Jul 18, 2017

ndhimehta assigned snapwich Jul 18, 2017

snapwich requested changes Jul 19, 2017

View reviewed changes

dmitriy-shimko-nrich added 3 commits July 27, 2017 17:33

Merge branch 'master' of https://github.com/prebid/Prebid.js

a24ab8a

Adding Orbitsoft module (correction of remarks)

42f1d66

Adding Orbitsoft module (correction of remarks)

aba01a3

rmloveland mentioned this pull request Jul 31, 2017

Orbitsoft adapter dev-doc prebid/prebid.github.io#296

Merged

snapwich requested changes Sep 13, 2017

View reviewed changes

dmitriy-shimko-nrich added 6 commits September 14, 2017 12:55

Adding Orbitsoft module (correction to alias-able)

be50c55

Adding Orbitsoft module (correction to alias-able)

0af08c9

Adding Orbitsoft module (correction to alias-able)

ccf57ef

Merge branch 'master' of https://github.com/prebid/Prebid.js

e492c4c

Adding Orbitsoft module (correction to alias-able)

28d89b0

Adding Orbitsoft module (correction to new constructor)

1c873a0

mkendall07 reviewed Sep 15, 2017

View reviewed changes

dmitriy-shimko-nrich added 2 commits September 15, 2017 15:42

Adding Orbitsoft module (delete unnecessary aliases)

6337b57

Adding Orbitsoft module (delete unnecessary aliases)

60aa74b

mkendall07 approved these changes Sep 15, 2017

View reviewed changes

mkendall07 merged commit d05af09 into prebid:master Sep 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Orbitsoft adapter #1378

Adding Orbitsoft adapter #1378

Indra-sensei commented Jul 13, 2017 •

edited

Loading

snapwich Jul 19, 2017

Indra-sensei Aug 17, 2017

snapwich Jul 19, 2017

Indra-sensei Jul 28, 2017

snapwich Jul 19, 2017

Indra-sensei Jul 28, 2017

mkendall07 commented Sep 13, 2017

snapwich Sep 13, 2017

Indra-sensei Sep 14, 2017

snapwich Sep 14, 2017

Indra-sensei Sep 15, 2017

mkendall07 Sep 15, 2017

Indra-sensei Sep 15, 2017 •

edited

Loading

mkendall07 Sep 15, 2017

Indra-sensei Sep 15, 2017

mkendall07 Sep 15, 2017

Indra-sensei Sep 15, 2017 •

edited

Loading

mkendall07 left a comment

Adding Orbitsoft adapter #1378

Adding Orbitsoft adapter #1378

Conversation

Indra-sensei commented Jul 13, 2017 • edited Loading

Type of change

Description of change

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkendall07 commented Sep 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Indra-sensei Sep 15, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Indra-sensei Sep 15, 2017 • edited Loading

Choose a reason for hiding this comment

mkendall07 left a comment

Choose a reason for hiding this comment

Indra-sensei commented Jul 13, 2017 •

edited

Loading

Indra-sensei Sep 15, 2017 •

edited

Loading

Indra-sensei Sep 15, 2017 •

edited

Loading