don't calculate TTR if request not found #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapwich
previously requested changes
Sep 11, 2017
src/bidmanager.js
Outdated
| @@ -161,7 +161,10 @@ exports.addBidResponse = function (adUnitCode, bid) { | |||
| adUnitCode | |||
| }); | |||
|
|
|||
| bid.timeToRespond = bid.responseTimestamp - bid.requestTimestamp; | |||
|
|
|||
There was a problem hiding this comment.
this extra newline is causing a linter error and failing the build
|
other than the linting error this LGTM. However, I'm wondering if we should be throwing this bid out even earlier if it isn't part of the current auction. It seems to me if it's not a valid bid for this current auction, |
|
That sounds good, I'll move the check to isValidBid() |
kitwestneat
force-pushed
the
fix-ttr
branch
from
1151024 to
1797293
Compare
Update tests to match.
kitwestneat
force-pushed
the
fix-ttr
branch
from
1797293 to
622aacf
Compare
mkendall07
requested changes
Sep 15, 2017
| @@ -109,6 +109,13 @@ exports.addBidResponse = function (adUnitCode, bid) { | |||
| utils.logError(errorMessage('No adUnitCode was supplied to addBidResponse.')); | |||
| return false; | |||
| } | |||
|
|
|||
| const bidRequest = getBidderRequest(bid.bidderCode, adUnitCode); | |||
| if (!bidRequest.start) { | |||
There was a problem hiding this comment.
if you trying to check for no bid request, I think this condition should be just if (!bidRequest) otherwise you'll get an undefined error.
|
Currently, getBidderRequest returns { start: null, requestId: null } if it
can't find a valid request. I agree that have getBidderRequest return
undefined or false makes more sense though.
…On Fri, Sep 15, 2017 at 7:36 AM, Matt Kendall ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In src/bidmanager.js
<#1575 (comment)>:
> @@ -109,6 +109,13 @@ exports.addBidResponse = function (adUnitCode, bid) {
utils.logError(errorMessage('No adUnitCode was supplied to addBidResponse.'));
return false;
}
+
+ const bidRequest = getBidderRequest(bid.bidderCode, adUnitCode);
+ if (!bidRequest.start) {
if you trying to check for no bid request, I think this condition should
be just if (!bidRequest) otherwise you'll get an undefined error.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1575 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANGyQ-UF_Fj31rfQcoVYdphsByteVwZks5simEggaJpZM4PTjN2>
.
|
|
oh I missed that. Seems odd but I'm not going to touch it now. Thanks |
mkendall07
approved these changes
Sep 15, 2017
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Sep 18, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (46 commits) Serverbid alias (prebid#1560) Add user sync to process for approving adapter PRs (prebid#1457) fix travis build (prebid#1595) Rubicon project improvement/user sync (prebid#1549) Adding Orbitsoft adapter (prebid#1378) Fix renderer test for new validation rule (prebid#1592) Allow SET_TARGETING to be used in AnalyticsAdapter (prebid#1577) Add support for video stream context (prebid#1483) Invalidate bid if matching bid request not found (prebid#1575) allow adapters to set default adserverTargeting for specific bid (prebid#1568) Custom granularity precision should honor 0 if it is passed in closes prebid#1479 (prebid#1591) BaseAdapter for the Prebid 0.x -> 1.x transition (prebid#1494) Add a version to the Criteo adapter (prebid#1573) Allow bundling from node.js or with new gulp task bundle-to-stdout (prebid#1570) Add url.parse option to not decode the whole URL (prebid#1480) Tremor Video Bid Adapter (prebid#1552) Yieldmo bid adapter (prebid#1415) Switch `gulp docs` to build its output using documentation.js (prebid#1545) Increment pre version Prebid 0.28.0 Release ...
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
Update tests to match.
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Sep 21, 2017
* tag '0.29.0' of https://github.com/prebid/Prebid.js: (29 commits) Prebid 0.29.0 Release Fix for not syncing bidders. (prebid#1598) fix amp example pages (prebid#1597) closes prebid#1298 (prebid#1583) Fixed the broken tests. (prebid#1602) Rubicon Bidder Factory (prebid#1587) Trustx adapter (prebid#1488) Add nurl to markup (prebid#1601) Pass bidRequest to createBid (prebid#1600) Add Kumma adapter (prebid#1512) Serverbid alias (prebid#1560) Add user sync to process for approving adapter PRs (prebid#1457) fix travis build (prebid#1595) Rubicon project improvement/user sync (prebid#1549) Adding Orbitsoft adapter (prebid#1378) Fix renderer test for new validation rule (prebid#1592) Allow SET_TARGETING to be used in AnalyticsAdapter (prebid#1577) Add support for video stream context (prebid#1483) Invalidate bid if matching bid request not found (prebid#1575) allow adapters to set default adserverTargeting for specific bid (prebid#1568) ...
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
Update tests to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
If the bidrequest can't be found, for example on a very late bid, don't try to calculate TTR. If the start time
is 0, then TTR will be huge and the current auction will immediately timeout.