Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of Prebid.js's speed #31

Closed
Heray opened this issue Aug 19, 2015 · 3 comments
Closed

Optimization of Prebid.js's speed #31

Heray opened this issue Aug 19, 2015 · 3 comments
Assignees
@Heray

Comments

@Heray
Copy link

Heray commented Aug 19, 2015

I noticed there's a 30-50ms lag between when Prebid.js finished loading and when the first pre-bid calls are initiated.

screen shot 2015-08-19 at 3 08 09 pm

This is a Chrome capture on page: http://prebid.org/header-bidding-demo.html
@BartVB
Copy link
Contributor

BartVB commented Nov 15, 2015

Same here. But as far as I can tell this is your browser parsing the Javascript.

Google Chrome gpt/prebid timeline

I'm not exactly a prebid.js or Javascript expert but I think it should be possible to reduce this parsing time by helping the JS engines a bit. This seems to be a useful article:
http://ariya.ofilabs.com/2012/07/lazy-parsing-in-javascript-engines.html
Or this older article:
http://googlecode.blogspot.nl/2009/09/gmail-for-mobile-html5-series-reducing.html
Not very elegant but functional :)

@Heray
Copy link
Author

Heray commented Mar 29, 2016

Thanks @BartVB ! We are adding a new feature (coming up soon), that allows Prebid to inform GPT send out the impression immediately after the timeout hits, without having to wait for GPT to load. Closing the ticket for now.

@Heray Heray closed this as completed Mar 29, 2016
@BartVB
Copy link
Contributor

BartVB commented Mar 29, 2016

That's great and this would really help reduce latency on a page level, but it would still be really nice if it were possible to make prebid.js faster.
Eliminating redundant adapters resulted in a big improvement for us.

lntho referenced this issue in openx/Prebid.js Oct 11, 2016
Merge pull request #31 from header-bidder/update_prebid_20161003
a853634 
Update prebid 20161003
@idettman idettman mentioned this issue Mar 18, 2019
Merged
2 tasks
@snyk-bot snyk-bot mentioned this issue Jul 8, 2021
Closed
msm0504 pushed a commit that referenced this issue Jul 19, 2021
@SublimeJeremy
Sublime Bid Adapter : send notid in pixel & use timeout from timeoutD…
4d38732 
…ata (#7167)

* DL-1746: Remove trId and use notid instead (#31)

* Remove trId and use notid instead
* Update version to 0.7.3
* Set default value to empty string

Co-authored-by: SublimeJeremy <jeremy@sublimeskinz.com>

* DL-1780: Fix pubtimeout (#32)

* Update timeout value with onTimeout data
* Add test for onTimeout
* Update state with timeout asap

Co-authored-by: SublimeJeremy <jeremy@sublimeskinz.com>
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this issue Nov 15, 2021
@SublimeJeremy @agrandes-tappx
Sublime Bid Adapter : send notid in pixel & use timeout from timeoutD…
7367025 
…ata (prebid#7167)

* DL-1746: Remove trId and use notid instead (prebid#31)

* Remove trId and use notid instead
* Update version to 0.7.3
* Set default value to empty string

Co-authored-by: SublimeJeremy <jeremy@sublimeskinz.com>

* DL-1780: Fix pubtimeout (prebid#32)

* Update timeout value with onTimeout data
* Add test for onTimeout
* Update state with timeout asap

Co-authored-by: SublimeJeremy <jeremy@sublimeskinz.com>
ChrisHuie pushed a commit that referenced this issue Apr 30, 2024
@nickllerandi @klawil
Kargo Bid Adapter: test spec overhaul (#11417)
ecb9218 
* KRKPD-1083: Refactor and expand testing (#31)

* Refactor the Kargo adapter testing to be more comprehensive and include testing of invalid inputs

* Fix the window size test to pull data from the browser instead of hardcoded values

* Remove a duplicate test

* unhook triggerPixel after tests

* fixes circleci failure

* Update the localStorage non-functional test

In FireFox, having localStorage.getItem throw an error isn't working so the test was updated to not have a valid localStorage
value to pass on FireFox.

* Restore the bidderSettings following testing

---------

Co-authored-by: William Klausmeyer <klawil@users.noreply.github.com>
Co-authored-by: “Nick <“nick.llerandi”@kargo.com>
Co-authored-by: William Klausmeyer <willyk95@gmail.com>
Ticki84 pushed a commit to criteo-forks/Prebid.js that referenced this issue May 14, 2024
@nickllerandi @klawil
Kargo Bid Adapter: test spec overhaul (prebid#11417)
0b5f521 
* KRKPD-1083: Refactor and expand testing (prebid#31)

* Refactor the Kargo adapter testing to be more comprehensive and include testing of invalid inputs

* Fix the window size test to pull data from the browser instead of hardcoded values

* Remove a duplicate test

* unhook triggerPixel after tests

* fixes circleci failure

* Update the localStorage non-functional test

In FireFox, having localStorage.getItem throw an error isn't working so the test was updated to not have a valid localStorage
value to pass on FireFox.

* Restore the bidderSettings following testing

---------

Co-authored-by: William Klausmeyer <klawil@users.noreply.github.com>
Co-authored-by: “Nick <“nick.llerandi”@kargo.com>
Co-authored-by: William Klausmeyer <willyk95@gmail.com>
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this issue Jul 18, 2024
@nickllerandi @klawil @DecayConstant
Kargo Bid Adapter: test spec overhaul (prebid#11417)
f9b28e6 
* KRKPD-1083: Refactor and expand testing (prebid#31)

* Refactor the Kargo adapter testing to be more comprehensive and include testing of invalid inputs

* Fix the window size test to pull data from the browser instead of hardcoded values

* Remove a duplicate test

* unhook triggerPixel after tests

* fixes circleci failure

* Update the localStorage non-functional test

In FireFox, having localStorage.getItem throw an error isn't working so the test was updated to not have a valid localStorage
value to pass on FireFox.

* Restore the bidderSettings following testing

---------

Co-authored-by: William Klausmeyer <klawil@users.noreply.github.com>
Co-authored-by: “Nick <“nick.llerandi”@kargo.com>
Co-authored-by: William Klausmeyer <willyk95@gmail.com>
dgirardi pushed a commit that referenced this issue Jan 6, 2025
@wojciech-bialy-wpm
Merge pull request #31 from prebid/master
cc82ed7 
Update remote repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Heray Heray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BartVB @Heray @mkendall07