Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update appnexusBidAdapter.js #4893

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Update appnexusBidAdapter.js #4893

merged 4 commits into from
Apr 15, 2020

Conversation

bllmo
Copy link
Contributor

@bllmo bllmo commented Feb 25, 2020 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added Beintoo as Appnexus alias

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@jsnellbaker jsnellbaker self-requested a review February 25, 2020 21:20
@jsnellbaker jsnellbaker self-assigned this Feb 25, 2020
@stale
Copy link

stale bot commented Mar 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 11, 2020
@jsnellbaker jsnellbaker removed the stale label Mar 11, 2020
@jsnellbaker
Copy link
Collaborator

Just to note - waiting on internal review/approval before merging this new alias.

@stale
Copy link

stale bot commented Mar 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 26, 2020
@bllmo
Copy link
Contributor Author

bllmo commented Mar 31, 2020

@jsnellbaker do you have any news about this new alias?

@stale stale bot removed the stale label Mar 31, 2020
@jsnellbaker
Copy link
Collaborator

@bllmo I have followed up again internally. Will hopefully have an answer soon.

jsnellbaker
jsnellbaker approved these changes Apr 10, 2020
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been internally approved.

@jsnellbaker
Copy link
Collaborator

@bllmo when you have the chance, can you please resolve the conflicts? We should be good to merge at that point.

jsnellbaker
jsnellbaker requested changes Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bllmo

Thanks for resolving the conflict. However it appears that something was removed accidentally. Please see the comment below and add it back into the adapter above the aliases param. Thanks!

modules/appnexusBidAdapter.js
@@ -44,8 +44,7 @@ const storage = getStorageManager(GVLID, BIDDER_CODE);

export const spec = {
code: BIDDER_CODE,
gvlid: GVLID,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this variable back into the spec object.

@ddantuonobeintoo
Copy link

Hi jsnellbaker let we know if now can be merge the code. Thanks

jsnellbaker
jsnellbaker approved these changes Apr 15, 2020
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update; LGTM

@jsnellbaker jsnellbaker merged commit 3fc10c9 into prebid:master Apr 15, 2020
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Apr 20, 2020
@redaguermas
Merge branch 'master' of https://github.com/prebid/Prebid.js
6b11e52 
* 'master' of https://github.com/prebid/Prebid.js:
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  Replace call to old url module with call to utils (prebid#5136)
  GumGum: uses encodeURIComponent inline (prebid#5124)
  User ID's (liveramp, britepool) and gdpr (prebid#5114)
  fix wipes adapter response (prebid#5134)
  Submitting Tercept Analytics Adapter (prebid#5099)
  hotfix - undefined consent (prebid#5127)
  parrableIdSystem: Send current page location to back-end (prebid#5123)
  Increment pre version
  Prebid 3.16.0 Release
  Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039)
  Update appnexusBidAdapter.js (prebid#4893)
  Quantcast: Block bids without purpose 1 consent (prebid#5046)
  ShowHeroes adapter v2 (prebid#5085)
  Qc/qc usersyncs (prebid#4923)
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Apr 20, 2020
@redaguermas
Merge branch 'master' into NoBid-Version-1.2.5
9d0db06 
* master:
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  Replace call to old url module with call to utils (prebid#5136)
  GumGum: uses encodeURIComponent inline (prebid#5124)
  User ID's (liveramp, britepool) and gdpr (prebid#5114)
  fix wipes adapter response (prebid#5134)
  Submitting Tercept Analytics Adapter (prebid#5099)
  hotfix - undefined consent (prebid#5127)
  parrableIdSystem: Send current page location to back-end (prebid#5123)
  Increment pre version
  Prebid 3.16.0 Release
  Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039)
  Update appnexusBidAdapter.js (prebid#4893)
  Quantcast: Block bids without purpose 1 consent (prebid#5046)
  ShowHeroes adapter v2 (prebid#5085)
  Qc/qc usersyncs (prebid#4923)
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
@bllmo @iggyfisk
Update appnexusBidAdapter.js (prebid#4893)
e52688b 
* Update appnexusBidAdapter.js

* Update appnexusBidAdapter.js

* Update appnexusBidAdapter.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@jsnellbaker jsnellbaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bllmo @jsnellbaker @ddantuonobeintoo