Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qc/qc usersyncs #4923

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Qc/qc usersyncs #4923

merged 2 commits into from
Apr 14, 2020

Conversation

SleimanJneidi
Copy link
Contributor

Type of change

  • Feature

Description of change

Adds support for userSyncs in QC adapter

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to include GDPR or CCPA consent strings in your sync requests?

@harpere harpere self-assigned this Mar 5, 2020
@SleimanJneidi
Copy link
Contributor Author

@harpere how would I do that?

@harpere
Copy link
Collaborator

harpere commented Mar 6, 2020

there are 2 more arguments passed to getUserSyncs(). for example:
https://github.com/prebid/Prebid.js/blob/master/modules/rubiconBidAdapter.js#L751

@lgtm-com
Copy link

lgtm-com bot commented Mar 9, 2020

This pull request introduces 1 alert when merging 7efbcde into 19b7319 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@SleimanJneidi
Copy link
Contributor Author

@harpere this will be appended on the server side

@SleimanJneidi
Copy link
Contributor Author

@hadarpeer do you mind having another look please?

@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 7, 2020
@stale stale bot removed the stale label Apr 14, 2020
@harpere harpere merged commit bcfca15 into prebid:master Apr 14, 2020
@SleimanJneidi SleimanJneidi deleted the qc/qc-usersyncs branch April 14, 2020 09:38
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Apr 20, 2020
* 'master' of https://github.com/prebid/Prebid.js:
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  Replace call to old url module with call to utils (prebid#5136)
  GumGum: uses encodeURIComponent inline (prebid#5124)
  User ID's (liveramp, britepool) and gdpr (prebid#5114)
  fix wipes adapter response (prebid#5134)
  Submitting Tercept Analytics Adapter (prebid#5099)
  hotfix - undefined consent (prebid#5127)
  parrableIdSystem: Send current page location to back-end (prebid#5123)
  Increment pre version
  Prebid 3.16.0 Release
  Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039)
  Update appnexusBidAdapter.js (prebid#4893)
  Quantcast: Block bids without purpose 1 consent (prebid#5046)
  ShowHeroes adapter v2 (prebid#5085)
  Qc/qc usersyncs (prebid#4923)
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Apr 20, 2020
* master:
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  Replace call to old url module with call to utils (prebid#5136)
  GumGum: uses encodeURIComponent inline (prebid#5124)
  User ID's (liveramp, britepool) and gdpr (prebid#5114)
  fix wipes adapter response (prebid#5134)
  Submitting Tercept Analytics Adapter (prebid#5099)
  hotfix - undefined consent (prebid#5127)
  parrableIdSystem: Send current page location to back-end (prebid#5123)
  Increment pre version
  Prebid 3.16.0 Release
  Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039)
  Update appnexusBidAdapter.js (prebid#4893)
  Quantcast: Block bids without purpose 1 consent (prebid#5046)
  ShowHeroes adapter v2 (prebid#5085)
  Qc/qc usersyncs (prebid#4923)
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* QC adapter. support usersyncs

* cache user sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants