Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting Tercept Analytics Adapter #5099

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

mohdusmanalvi
Copy link
Contributor

@mohdusmanalvi mohdusmanalvi commented Apr 9, 2020

…it test file
terceptAnalyticsAdapter_spec.js

Type of change

  • Bugfix
  • [ x] Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Adding a new Analytics Adapter.

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@mohdusmanalvi
Copy link
Contributor Author

Hi @msm0504
When we ran circle ci tests with the main branch on the forked, they passed. So could you suggest what could possibly be the issue thats causing it to fail in the main repo?

@msm0504
Copy link
Contributor

msm0504 commented Apr 10, 2020

@mohdusmanalvi I'm not sure exactly. I'll try rerunning the tests. Also, can you merge the latest prebid:master into your fork?

@mohdusmanalvi
Copy link
Contributor Author

@msm0504 The prebid:master is up to date in my fork.

@mohdusmanalvi
Copy link
Contributor Author

@msm0504 I was also wondering, if you could please let me know, what is the usual timeline for a new analytics adapter to get merged into the main repo? Thanks a lot in advance.

@msm0504
Copy link
Contributor

msm0504 commented Apr 15, 2020

@mohdusmanalvi I'm reviewing this today

modules/terceptAnalyticsAdapter.js Outdated Show resolved Hide resolved
modules/terceptAnalyticsAdapter.js Outdated Show resolved Hide resolved
modules/terceptAnalyticsAdapter.js Outdated Show resolved Hide resolved
…ata.auctionInit is assignment location params (from review requested changes)
Copy link
Contributor

@msm0504 msm0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msm0504 msm0504 added LGTM and removed needs review labels Apr 16, 2020
@msm0504 msm0504 merged commit bab538b into prebid:master Apr 16, 2020
@msm0504
Copy link
Contributor

msm0504 commented Apr 16, 2020

@mohdusmanalvi I've approved and merged this PR. This new analytics adapter will be released in Prebid.js version 3.17.0

@mohdusmanalvi
Copy link
Contributor Author

@msm0504 Thank you very much! May I ask, whats the timline for v 3.17.0 release?

@harpere
Copy link
Collaborator

harpere commented Apr 17, 2020

@msm0504 and @mohdusmanalvi I believe it's this PR that is causing lint failures. for example: https://circleci.com/gh/prebid/Prebid.js/7593?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

/home/circleci/Prebid.js/modules/terceptAnalyticsAdapter.js
  5:1  error  import "../src/url.js" cannot be resolved  prebid/validate-imports

✖ 1 problem (1 error, 0 warnings)

[23:26:13] 'lint' errored after 27 s
[23:26:13] ESLintError in plugin "gulp-eslint"
Message:
    Failed with 1 error
Details:
    domainEmitter: [object Object]
    domain: [object Object]
    domainThrown: false

[23:26:13] 'test' errored after 27 s

Exited with code exit status 1

@musikele
Copy link
Contributor

I also see the same error @harpere has , can we fix it?

redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Apr 20, 2020
* 'master' of https://github.com/prebid/Prebid.js:
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  Replace call to old url module with call to utils (prebid#5136)
  GumGum: uses encodeURIComponent inline (prebid#5124)
  User ID's (liveramp, britepool) and gdpr (prebid#5114)
  fix wipes adapter response (prebid#5134)
  Submitting Tercept Analytics Adapter (prebid#5099)
  hotfix - undefined consent (prebid#5127)
  parrableIdSystem: Send current page location to back-end (prebid#5123)
  Increment pre version
  Prebid 3.16.0 Release
  Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039)
  Update appnexusBidAdapter.js (prebid#4893)
  Quantcast: Block bids without purpose 1 consent (prebid#5046)
  ShowHeroes adapter v2 (prebid#5085)
  Qc/qc usersyncs (prebid#4923)
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Apr 20, 2020
* master:
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  Replace call to old url module with call to utils (prebid#5136)
  GumGum: uses encodeURIComponent inline (prebid#5124)
  User ID's (liveramp, britepool) and gdpr (prebid#5114)
  fix wipes adapter response (prebid#5134)
  Submitting Tercept Analytics Adapter (prebid#5099)
  hotfix - undefined consent (prebid#5127)
  parrableIdSystem: Send current page location to back-end (prebid#5123)
  Increment pre version
  Prebid 3.16.0 Release
  Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039)
  Update appnexusBidAdapter.js (prebid#4893)
  Quantcast: Block bids without purpose 1 consent (prebid#5046)
  ShowHeroes adapter v2 (prebid#5085)
  Qc/qc usersyncs (prebid#4923)
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* files for Tercept Analytics Adapter and corresponding markdown and unit test file

* replaced all == with ===, removed redundant else if and changed how data.auctionInit is assignment location params (from review requested changes)

Co-authored-by: MohdUsmanAlvi <usman.alvi@tercept.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants