Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ix endpoint upgrade #826

Merged
merged 2 commits into from
Dec 15, 2016
Merged

Conversation

indexexchange
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

  • Changing IX end point from headertag to cygnus
  • Deprecating unused variable – index_slots.
  • Additional IX custom targets and render functions.
  • sandbox mode now checks parent frames for query string parameter

Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass and ads are returned, reviewed.

@protonate protonate merged commit fd87aa3 into prebid:master Dec 15, 2016
@wrosenbergatappnexus
Copy link

Is it normal behavior for Index to return multiple bids per slot?

Additionally, I am seeing a situation where Index returns multiple bids per slot, and the higher bid is submitted with hb_pb etc. keys, and the lower bid is passed in through the hb_pb_indexexchange key. Thus, the lower bid is sent to the DFP auction.

I saw the behavior happening on this site: http://bit.ly/2nt0A9Q; prebid.js: 0.19.0; Google Chrome 56.0.2924.87

@protonate
Copy link
Collaborator

It is expected in cases for multi-size ad units as IX makes a request per size. The highest IX bid should always be set as auction winner keys when IX wins. As for the bid landscape keys, I'm not sure that those keys would always be the second lower bid.

@wrosenbergatappnexus
Copy link

Ok thanks for confirming they send multiple bids.

The client is using "Send All Bids". I'd expect if an IX bid wins, it should be inserted for auction winner keys and bid landscape keys, since the bid landscape keys are targeted by Index specific DFP line items, but that didn't seem to always be the case.
screen shot 2017-03-06 at 1 15 12 pm

mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…ebid-official-0.17.0 to release/1.12.0

* commit 'bce975978c2c088d301d120b949d38080ca9d314':
  Add changelog entry.
  Prebid Release 0.17.0
  remove hb_pb targeting key for deal bids with no cpm (prebid#881)
  Fix for bug prebid#866 (prebid#867)
  Allow changing of 'ga' global variable (prebid#832)
  emit auction end event before bidsBackHandler callback (prebid#884)
  Add Widespace adapter (prebid#846)
  prevent rubicon adapter from registering two bids on exceptions (prebid#854)
  Code Refactoring - Upgrading end point. (prebid#826)
  Ignore test html pages (prebid#878)
  Detect browser width instead of the screen width (prebid#837)
  New aardvark adapter with support for aliasing (prebid#875)
  Add Fidelity adapter (prebid#862)
  Adkernel adapter aliasing (prebid#857)
  0.16.1-pre
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…12.0 to master

* commit '728f1763ce2a282a757546e934199313a4771a21':
  Fix failing unit test on CI.
  Add changelog entry.
  Prebid Release 0.17.0
  remove hb_pb targeting key for deal bids with no cpm (prebid#881)
  Fix for bug prebid#866 (prebid#867)
  Allow changing of 'ga' global variable (prebid#832)
  emit auction end event before bidsBackHandler callback (prebid#884)
  Add Widespace adapter (prebid#846)
  prevent rubicon adapter from registering two bids on exceptions (prebid#854)
  Code Refactoring - Upgrading end point. (prebid#826)
  Ignore test html pages (prebid#878)
  Detect browser width instead of the screen width (prebid#837)
  New aardvark adapter with support for aliasing (prebid#875)
  Add Fidelity adapter (prebid#862)
  Adkernel adapter aliasing (prebid#857)
  0.16.1-pre
@arvending arvending mentioned this pull request Jul 28, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants