Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New aardvark adapter with support for aliasing #875

Merged
merged 1 commit into from
Dec 14, 2016

Conversation

dejanstrbac
Copy link
Contributor

@dejanstrbac dejanstrbac commented Dec 13, 2016

Type of change

  • Code style update (formatting, local variables)
  • Feature
  • Refactoring (no functional changes, no api changes)
  • CI related changes

Description of change

The Aardvark adapter now supports aliasing using the new adapter specs of Prebid.js. Tests have been updated accordingly.

An additional parameter is introduced - "host" which can be used to CNAME the aardvark endpoint.

{
  bidder: 'aardvark',
  params: {
    host: 'host.example.net'
    sc: '...',
    ai: '...'
  }
}
  • official adapter submission

@dejanstrbac dejanstrbac force-pushed the aardvark_adapter_update branch from b6006f4 to 6558cd6 Compare December 14, 2016 10:26
@matthewlane
Copy link
Collaborator

Thanks for this update to aardvark. The bidder params I previously used for testing were

{
  bidder:"aardvark",
  params: {
    "ai": "Ohot",
    "sc": "sXvU"
  }
}

but currently getting a warning of Aardvark bid received with an error, ignoring... [No bids received]. Are these params still valid for testing?

@dejanstrbac
Copy link
Contributor Author

Thanks for reviewing. This just means you've got no bids for you.

@matthewlane
Copy link
Collaborator

matthewlane commented Dec 14, 2016

Ok. Which parameters can I use for validating test bids with this update?

Edit: I'm seeing bids with those params now, thanks

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and validated bids and aliasing support

@matthewlane matthewlane merged commit 49321de into prebid:master Dec 14, 2016
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…ebid-official-0.17.0 to release/1.12.0

* commit 'bce975978c2c088d301d120b949d38080ca9d314':
  Add changelog entry.
  Prebid Release 0.17.0
  remove hb_pb targeting key for deal bids with no cpm (prebid#881)
  Fix for bug prebid#866 (prebid#867)
  Allow changing of 'ga' global variable (prebid#832)
  emit auction end event before bidsBackHandler callback (prebid#884)
  Add Widespace adapter (prebid#846)
  prevent rubicon adapter from registering two bids on exceptions (prebid#854)
  Code Refactoring - Upgrading end point. (prebid#826)
  Ignore test html pages (prebid#878)
  Detect browser width instead of the screen width (prebid#837)
  New aardvark adapter with support for aliasing (prebid#875)
  Add Fidelity adapter (prebid#862)
  Adkernel adapter aliasing (prebid#857)
  0.16.1-pre
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…12.0 to master

* commit '728f1763ce2a282a757546e934199313a4771a21':
  Fix failing unit test on CI.
  Add changelog entry.
  Prebid Release 0.17.0
  remove hb_pb targeting key for deal bids with no cpm (prebid#881)
  Fix for bug prebid#866 (prebid#867)
  Allow changing of 'ga' global variable (prebid#832)
  emit auction end event before bidsBackHandler callback (prebid#884)
  Add Widespace adapter (prebid#846)
  prevent rubicon adapter from registering two bids on exceptions (prebid#854)
  Code Refactoring - Upgrading end point. (prebid#826)
  Ignore test html pages (prebid#878)
  Detect browser width instead of the screen width (prebid#837)
  New aardvark adapter with support for aliasing (prebid#875)
  Add Fidelity adapter (prebid#862)
  Adkernel adapter aliasing (prebid#857)
  0.16.1-pre
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants